From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Fri, 13 Jan 2012 20:55:23 -0500 Message-ID: References: <87mx9su32g.fsf@web.de> <87sjjkfvwt.fsf@gmail.com> <8362ggkquq.fsf@gnu.org> <87lipcrlga.fsf@gmail.com> <87fwfkc4pn.fsf@gmx.de> <87fwfjsw8t.fsf@gmail.com> <87aa5rdazl.fsf@gmx.de> <87d3anogf5.fsf@gmail.com> <011AEED9E81C4DEFA6B1E03B0F57F28F@us.oracle.com> <878vlbljnc.fsf@gmx.de> <8739bj8mu1.fsf@gmail.com> <8762gfnrlj.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326506202 22415 80.91.229.12 (14 Jan 2012 01:56:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 14 Jan 2012 01:56:42 +0000 (UTC) Cc: 10489@debbugs.gnu.org, Thierry Volpiatto To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 14 02:56:38 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RlsrF-0003Gz-Gd for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jan 2012 02:56:38 +0100 Original-Received: from localhost ([::1]:47666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlsr5-00019u-5u for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2012 20:56:27 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:55252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlsr1-00018k-NW for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 20:56:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rlsr0-0004K5-KH for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 20:56:23 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlsr0-0004K1-HT for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 20:56:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Rlsre-000311-2Y for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 20:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jan 2012 01:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.132650616711525 (code B ref 10489); Sat, 14 Jan 2012 01:57:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 14 Jan 2012 01:56:07 +0000 Original-Received: from localhost ([127.0.0.1]:56925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rlsql-0002zp-LA for submit@debbugs.gnu.org; Fri, 13 Jan 2012 20:56:07 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:21092) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rlsqj-0002zh-GQ for 10489@debbugs.gnu.org; Fri, 13 Jan 2012 20:56:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EAGrfEE9FxKkV/2dsb2JhbABDqwKCM4EGgXIBAQQBViMQCzQSFBgNJIgNtxGMFwSIO5phhFI X-IronPort-AV: E=Sophos;i="4.71,508,1320642000"; d="scan'208";a="156717350" Original-Received: from 69-196-169-21.dsl.teksavvy.com (HELO ceviche.home) ([69.196.169.21]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Jan 2012 20:55:24 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id F27E16610D; Fri, 13 Jan 2012 20:55:23 -0500 (EST) In-Reply-To: <8762gfnrlj.fsf@gmx.de> (Michael Albinus's message of "Fri, 13 Jan 2012 23:51:52 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55722 Archived-At: >> There's a crucial line missing between the above two. It should clearly >> document what this function is expected to do. E.g. it should make it >> clear if (and if so, to what extent) the function is allowed to refer to >> the actual file system(s) as opposed to only relying on the >> provided strings. > If the file name strings are not obviously equal, `file-truename' will I don't mean "document what the code currently does" but "document what the code should do". > "Return non-nil if NAME1 and NAME2 refer to the same file in the file system. > If either name is not absolute, then it is expanded relative to > DIR (if given) or `default-directory' for the test." That description is too vague: an implementation based on comparing file-attributes would seem to fit, whereas it's clearly not the semantic we want to provide. Stefan