From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107377: * src/lisp.h: Improve comment about USE_LSB_TAG. Date: Sat, 25 Feb 2012 05:06:13 -0500 Message-ID: References: <4F459455.8070206@verizon.net> <4F45DD5B.3010801@cs.ucla.edu> <4F488717.2060108@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330164393 26114 80.91.229.3 (25 Feb 2012 10:06:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 25 Feb 2012 10:06:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 25 11:06:33 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S1EWN-00076d-Mh for ged-emacs-devel@m.gmane.org; Sat, 25 Feb 2012 11:06:31 +0100 Original-Received: from localhost ([::1]:54768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1EWN-00040s-1r for ged-emacs-devel@m.gmane.org; Sat, 25 Feb 2012 05:06:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1EWD-00040d-Uk for emacs-devel@gnu.org; Sat, 25 Feb 2012 05:06:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1EW6-0002zm-WB for emacs-devel@gnu.org; Sat, 25 Feb 2012 05:06:21 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:37361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1EW6-0002zi-Rb for emacs-devel@gnu.org; Sat, 25 Feb 2012 05:06:14 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9MCodT/2dsb2JhbACBX5x7eYhwnhmGGQSGUJBsg12DOFM X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="164544273" Original-Received: from 76-10-135-83.dsl.teksavvy.com (HELO pastel.home) ([76.10.135.83]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Feb 2012 05:06:14 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id A7CC659673; Sat, 25 Feb 2012 05:06:13 -0500 (EST) In-Reply-To: <4F488717.2060108@cs.ucla.edu> (Paul Eggert's message of "Fri, 24 Feb 2012 23:00:39 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148775 Archived-At: >> What I suggest is just to take the O(N) pointer-sized entities on >> the stack, cast them to EMACS_INT, and pass them to >> mark_maybe_object. > Thanks, I see now. Something like the following, then. > Yes, that does simplify things. Your patch doesn't look bad, but is too intrusive for 24.1. I think for 24.1 we can install one that just does: > for (pp = start; (void *) pp < end; pp++) > for (i = 0; i < sizeof *pp; i += GC_POINTER_ALIGNMENT) > - mark_maybe_pointer (*(void **) ((char *) pp + i)); > + { > + void *p = *(void **) ((char *) pp + i); > + mark_maybe_pointer (p); > + #ifdef WIDE_EMACS_INT > + mark_maybe_object (widen_to_Lisp_Object (p)); > + #endif > + } > } With an appropriate comment (mostly moved from the USE_LSB_TAG comment which can be trimmed down since the avoidance of USE_LSB_TAG on WIDE_EMACS_INT is not performed for correctness reasons any more). Stefan