* bug#10937: 24.0.94; fix savehist-printable
@ 2012-03-04 9:15 Leo
2012-03-09 18:12 ` Leo
2012-03-21 17:55 ` Stefan Monnier
0 siblings, 2 replies; 3+ messages in thread
From: Leo @ 2012-03-04 9:15 UTC (permalink / raw)
To: 10937
In savehist-printable, strings are not necessary printable. They can
contain anything in their properties. Because of this I have kill-ring
emptied for almost every restart of emacs.
I propose:
diff --git a/lisp/savehist.el b/lisp/savehist.el
index c1515fa4..a3ba9f1a 100644
--- a/lisp/savehist.el
+++ b/lisp/savehist.el
@@ -369,7 +369,7 @@ (defun savehist-printable (value)
"Return non-nil if VALUE is printable."
(cond
;; Quick response for oft-encountered types known to be printable.
- ((stringp value))
+ ((equal-including-properties value (substring-no-properties value)))
((numberp value))
((symbolp value))
(t
or just remove (stringp value) and let the default handle it.
Leo
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#10937: 24.0.94; fix savehist-printable
2012-03-04 9:15 bug#10937: 24.0.94; fix savehist-printable Leo
@ 2012-03-09 18:12 ` Leo
2012-03-21 17:55 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Leo @ 2012-03-09 18:12 UTC (permalink / raw)
To: 10937-done
Fixed in 24.0.95.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#10937: 24.0.94; fix savehist-printable
2012-03-04 9:15 bug#10937: 24.0.94; fix savehist-printable Leo
2012-03-09 18:12 ` Leo
@ 2012-03-21 17:55 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2012-03-21 17:55 UTC (permalink / raw)
To: Leo; +Cc: 10937
> In savehist-printable, strings are not necessary printable. They can
> contain anything in their properties. Because of this I have kill-ring
> emptied for almost every restart of Emacs.
Maybe we should strip their properties?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-21 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-04 9:15 bug#10937: 24.0.94; fix savehist-printable Leo
2012-03-09 18:12 ` Leo
2012-03-21 17:55 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.