From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 11348@debbugs.gnu.org
Subject: bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows
Date: Sat, 05 May 2012 00:20:17 -0400 [thread overview]
Message-ID: <jwv8vh79tx4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83mx5n6ceu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 May 2012 21:15:05 +0300")
>> This said, based on your description, the problem may simply come from
>> shell.el's setting of pcomplete-arg-quote-list which tells pcomplete
>> that \ is an escape char.
>> I.e. does the patch below fix the problem?
> No, I still get "d:\/gnu/".
I installed the patch below, which seems to fix this specific problem
(according to my testing under Wine ;-)
>> Which part is ugly? The \, the /, or the use of a mix of them?
> The mix.
Yes, I think I agree. I'll have to think about it some more.
Stefan
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-05-04 10:26:36 +0000
+++ lisp/ChangeLog 2012-05-05 04:16:59 +0000
@@ -1,3 +1,10 @@
+2012-05-05 Stefan Monnier <monnier@iro.umontreal.ca>
+
+ * shell.el (shell-completion-vars): Set pcomplete-arg-quote-list like
+ shell-delimiter-argument-list.
+ (shell-parse-pcomplete-arguments):
+ Obey pcomplete-arg-quote-list (bug#11348).
+
2012-05-04 Chong Yidong <cyd@gnu.org>
* select.el (xselect--encode-string): Always use utf-8 for TEXT on
=== modified file 'lisp/shell.el'
--- lisp/shell.el 2012-02-28 08:17:21 +0000
+++ lisp/shell.el 2012-05-05 04:13:57 +0000
@@ -393,8 +393,11 @@
(goto-char (match-end 0))
(cond
((match-beginning 3) ;Backslash escape.
- (push (if (= (match-beginning 3) (match-end 3))
- "\\" (match-string 3))
+ (push (cond
+ ((null pcomplete-arg-quote-list)
+ (goto-char (match-beginning 3)) "\\")
+ ((= (match-beginning 3) (match-end 3)) "\\")
+ (t (match-string 3)))
arg))
((match-beginning 2) ;Double quote.
(push (replace-regexp-in-string
@@ -429,7 +432,7 @@
(set (make-local-variable 'pcomplete-parse-arguments-function)
#'shell-parse-pcomplete-arguments)
(set (make-local-variable 'pcomplete-arg-quote-list)
- (append "\\ \t\n\r\"'`$|&;(){}[]<>#" nil))
+ shell-delimiter-argument-list)
(set (make-local-variable 'pcomplete-termination-string)
(cond ((not comint-completion-addsuffix) "")
((stringp comint-completion-addsuffix)
next prev parent reply other threads:[~2012-05-05 4:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 11:09 bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows Eli Zaretskii
2012-05-04 7:10 ` Eli Zaretskii
2012-05-04 14:29 ` Chong Yidong
2012-05-04 14:54 ` Eli Zaretskii
2012-05-04 15:07 ` Drew Adams
2012-05-04 15:36 ` Chong Yidong
2012-05-04 15:02 ` Eli Zaretskii
2012-05-04 15:46 ` Chong Yidong
2012-05-04 17:01 ` Eli Zaretskii
2012-05-04 17:59 ` Stefan Monnier
2012-05-04 18:15 ` Eli Zaretskii
2012-05-04 23:32 ` Stefan Monnier
2012-05-05 0:22 ` Drew Adams
2012-05-05 12:47 ` Eli Zaretskii
2012-05-05 4:20 ` Stefan Monnier [this message]
2012-05-05 6:33 ` Eli Zaretskii
2012-05-07 8:01 ` Chong Yidong
2012-05-07 17:40 ` Eli Zaretskii
2012-05-07 15:27 ` Stefan Monnier
2012-05-07 15:44 ` Drew Adams
2012-05-07 16:11 ` Chong Yidong
2012-05-08 0:27 ` Stefan Monnier
2012-05-08 18:56 ` Eli Zaretskii
2012-05-09 17:22 ` Stefan Monnier
2012-05-09 18:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8vh79tx4.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11348@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.