* bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c?
@ 2012-05-23 15:03 Ken Brown
2012-05-23 19:50 ` Jan Djärv
0 siblings, 1 reply; 5+ messages in thread
From: Ken Brown @ 2012-05-23 15:03 UTC (permalink / raw
To: 11547
In the course of trying to debug a Cygwin crash, I noticed that line 643
of callproc.c is commented out. This was done in bzr revision 103252,
and it seems pretty clear from the context of that change that it was
done by accident:
revno: 103252
committer: Jan D <jan.h.d@swipnet.se>
branch nick: trunk
timestamp: Sun 2011-02-13 12:28:42 +0100
message:
* callproc.c (Fcall_process):
* process.c (create_process): Replace Gtk with GConf in SIGPIPE
comment.
modified:
src/ChangeLog
src/callproc.c
src/process.c
diff:
=== modified file 'src/ChangeLog'
--- src/ChangeLog 2011-02-13 00:16:28 +0000
+++ src/ChangeLog 2011-02-13 11:28:42 +0000
@@ -1,3 +1,9 @@
+2011-02-13 Jan Djärv <jan.h.d@swipnet.se>
+
+ * callproc.c (Fcall_process):
+ * process.c (create_process): Replace Gtk with GConf in SIGPIPE
+ comment.
+
2011-02-12 Martin Rudalics <rudalics@gmx.at>
* window.c (select_window): Check inhibit_point_swap argument when
=== modified file 'src/callproc.c'
--- src/callproc.c 2011-02-12 18:53:24 +0000
+++ src/callproc.c 2011-02-13 11:28:42 +0000
@@ -559,9 +559,9 @@
setpgrp (pid, pid);
#endif /* USG */
- /* GTK causes us to ignore SIGPIPE, make sure it is restored
+ /* GConf causes us to ignore SIGPIPE, make sure it is restored
in the child. */
- signal (SIGPIPE, SIG_DFL);
+ //signal (SIGPIPE, SIG_DFL);
#ifdef HAVE_WORKING_VFORK
sigprocmask (SIG_SETMASK, &procmask, 0);
#endif
=== modified file 'src/process.c'
--- src/process.c 2011-02-12 18:53:24 +0000
+++ src/process.c 2011-02-13 11:28:42 +0000
@@ -2056,7 +2056,7 @@
signal (SIGINT, SIG_DFL);
signal (SIGQUIT, SIG_DFL);
- /* GTK causes us to ignore SIGPIPE, make sure it is restored
+ /* GConf causes us to ignore SIGPIPE, make sure it is restored
in the child. */
signal (SIGPIPE, SIG_DFL);
I don't understand the code well enough to know how critical this is.
The comment preceding that line suggests that it could be a problem for
a build with GConf support.
Ken
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c?
2012-05-23 15:03 bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c? Ken Brown
@ 2012-05-23 19:50 ` Jan Djärv
2012-05-23 20:10 ` Ken Brown
0 siblings, 1 reply; 5+ messages in thread
From: Jan Djärv @ 2012-05-23 19:50 UTC (permalink / raw
To: Ken Brown; +Cc: 11547
Hello.
It sure looks like I messed up. Can you restore the line? I don't have bzr access right now.
I guess it needs to be done in the 24 branch also.
See bug#5238 (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5238) for its impact.
Jan D.
23 maj 2012 kl. 17:03 skrev Ken Brown:
> In the course of trying to debug a Cygwin crash, I noticed that line 643 of callproc.c is commented out. This was done in bzr revision 103252, and it seems pretty clear from the context of that change that it was done by accident:
>
> revno: 103252
> committer: Jan D <jan.h.d@swipnet.se>
> branch nick: trunk
> timestamp: Sun 2011-02-13 12:28:42 +0100
> message:
> * callproc.c (Fcall_process):
> * process.c (create_process): Replace Gtk with GConf in SIGPIPE
> comment.
> modified:
> src/ChangeLog
> src/callproc.c
> src/process.c
> diff:
> === modified file 'src/ChangeLog'
> --- src/ChangeLog 2011-02-13 00:16:28 +0000
> +++ src/ChangeLog 2011-02-13 11:28:42 +0000
> @@ -1,3 +1,9 @@
> +2011-02-13 Jan Djärv <jan.h.d@swipnet.se>
> +
> + * callproc.c (Fcall_process):
> + * process.c (create_process): Replace Gtk with GConf in SIGPIPE
> + comment.
> +
> 2011-02-12 Martin Rudalics <rudalics@gmx.at>
>
> * window.c (select_window): Check inhibit_point_swap argument when
>
> === modified file 'src/callproc.c'
> --- src/callproc.c 2011-02-12 18:53:24 +0000
> +++ src/callproc.c 2011-02-13 11:28:42 +0000
> @@ -559,9 +559,9 @@
> setpgrp (pid, pid);
> #endif /* USG */
>
> - /* GTK causes us to ignore SIGPIPE, make sure it is restored
> + /* GConf causes us to ignore SIGPIPE, make sure it is restored
> in the child. */
> - signal (SIGPIPE, SIG_DFL);
> + //signal (SIGPIPE, SIG_DFL);
> #ifdef HAVE_WORKING_VFORK
> sigprocmask (SIG_SETMASK, &procmask, 0);
> #endif
>
> === modified file 'src/process.c'
> --- src/process.c 2011-02-12 18:53:24 +0000
> +++ src/process.c 2011-02-13 11:28:42 +0000
> @@ -2056,7 +2056,7 @@
>
> signal (SIGINT, SIG_DFL);
> signal (SIGQUIT, SIG_DFL);
> - /* GTK causes us to ignore SIGPIPE, make sure it is restored
> + /* GConf causes us to ignore SIGPIPE, make sure it is restored
> in the child. */
> signal (SIGPIPE, SIG_DFL);
>
>
> I don't understand the code well enough to know how critical this is. The comment preceding that line suggests that it could be a problem for a build with GConf support.
>
> Ken
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c?
2012-05-23 19:50 ` Jan Djärv
@ 2012-05-23 20:10 ` Ken Brown
2012-05-24 7:01 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Ken Brown @ 2012-05-23 20:10 UTC (permalink / raw
To: Jan Djärv; +Cc: 11547
On 5/23/2012 3:50 PM, Jan Djärv wrote:
> Hello.
>
> It sure looks like I messed up. Can you restore the line? I don't have bzr access right now.
> I guess it needs to be done in the 24 branch also.
>
> See bug#5238 (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5238) for its impact.
Sure, I'll be glad to do it. But I'd like explicit approval from Stefan
or Chong before committing anything to the emacs-24 branch.
Ken
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c?
2012-05-23 20:10 ` Ken Brown
@ 2012-05-24 7:01 ` Stefan Monnier
2012-05-24 11:24 ` Ken Brown
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2012-05-24 7:01 UTC (permalink / raw
To: Ken Brown; +Cc: 11547
>> Hello.
>>
>> It sure looks like I messed up. Can you restore the line? I don't have bzr access right now.
>> I guess it needs to be done in the 24 branch also.
>>
>> See bug#5238 (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5238) for its impact.
> Sure, I'll be glad to do it. But I'd like explicit approval from Stefan or
> Chong before committing anything to the emacs-24 branch.
Please go ahead and install it on the emacs-24 branch (only: not on the
trunk).
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c?
2012-05-24 7:01 ` Stefan Monnier
@ 2012-05-24 11:24 ` Ken Brown
0 siblings, 0 replies; 5+ messages in thread
From: Ken Brown @ 2012-05-24 11:24 UTC (permalink / raw
To: Stefan Monnier; +Cc: 11547-done
> Please go ahead and install it on the emacs-24 branch (only: not on the
> trunk).
Installed as bzr revision 108013 on the emacs-24 branch; I'm closing the
bug.
Ken
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-05-24 11:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-23 15:03 bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c? Ken Brown
2012-05-23 19:50 ` Jan Djärv
2012-05-23 20:10 ` Ken Brown
2012-05-24 7:01 ` Stefan Monnier
2012-05-24 11:24 ` Ken Brown
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.