From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 14153@debbugs.gnu.org
Subject: bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args
Date: Sat, 06 Apr 2013 20:46:10 -0400 [thread overview]
Message-ID: <jwv8v4v2mpc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> (Drew Adams's message of "Sat, 6 Apr 2013 14:25:34 -0700")
> Each such function should accept 4 args, as follows:
> CHOICE - the string to insert in the buffer,
> BUFFER - the buffer in which the choice should be inserted,
> MINI-P - non-nil if BUFFER is a minibuffer, and
> BASE-SIZE - the number of characters in BUFFER before
> the string being completed.
Duh, sorry indeed, could you please update this docstring to match the code?
> But `crm--choose-completion-string' expects these args:
> (CHOICE BUFFER BASE-POSITION &rest IGNORED)
Which is indeed the correct calling convention nowadays.
Stefan
next prev parent reply other threads:[~2013-04-07 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 21:25 bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Drew Adams
2013-04-07 0:46 ` Stefan Monnier [this message]
2013-04-07 2:00 ` Drew Adams
2013-04-07 2:09 ` Drew Adams
2014-02-08 12:46 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8v4v2mpc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14153@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.