From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv3 0/3] Add `notes' function, take three Date: Fri, 21 Jun 2013 11:21:58 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1371828125 20594 80.91.229.3 (21 Jun 2013 15:22:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Jun 2013 15:22:05 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org To: Michal Nazarewicz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 21 17:22:05 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uq3A5-0002hz-2r for ged-emacs-devel@m.gmane.org; Fri, 21 Jun 2013 17:22:05 +0200 Original-Received: from localhost ([::1]:52740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq3A4-0003un-MG for ged-emacs-devel@m.gmane.org; Fri, 21 Jun 2013 11:22:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq3A0-0003uU-CF for emacs-devel@gnu.org; Fri, 21 Jun 2013 11:22:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uq39z-0004Cb-7U for emacs-devel@gnu.org; Fri, 21 Jun 2013 11:22:00 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:39297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq39z-0004CX-4G for emacs-devel@gnu.org; Fri, 21 Jun 2013 11:21:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpZVy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IPAS-Result: Av4EABK/CFFFpZVy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="16878054" Original-Received: from 69-165-149-114.dsl.teksavvy.com (HELO pastel.home) ([69.165.149.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 Jun 2013 11:21:53 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1262662CFF; Fri, 21 Jun 2013 11:21:58 -0400 (EDT) In-Reply-To: (Michal Nazarewicz's message of "Fri, 21 Jun 2013 14:16:40 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160839 Archived-At: > Change to kill-buffer allowed an advice to be replaced with a hook, OK > and after looking more closely at remember.el, I think notes might be > a good fit for it. Indeed. Why even define a separate notes-file? And why not use (find-file-noselect notes-file), maybe followed by a rename-buffer? > Stefan, are you still not convinced, and prefer to have it in ELPA > after all? No, I think remember.el is a good place for it. It would also be good to use the "remember-" prefix. > The second patch is actually unrelated, but something I've noticed > while playing with notes. Good point. I think we should turn get-file-buffer into an alias for find-buffer-visiting. Stefan