all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Daniel Colascione <dancol@dancol.org>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Set operations on bool-vectors
Date: Fri, 20 Sep 2013 21:57:04 -0400	[thread overview]
Message-ID: <jwv8uyrc59w.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <523CD363.6020400@dancol.org> (Daniel Colascione's message of "Fri, 20 Sep 2013 15:59:47 -0700")

> I've implemented built-in set operations on bool vectors.

Thanks.  Looks good.

> According to my benchmarks, these operations are about 1,000 times
> faster than the compiled elisp equivalents.

I'd expect no less.

> === modified file 'src/alloc.c'
> --- src/alloc.c	2013-09-04 22:34:04 +0000
> +++ src/alloc.c	2013-09-19 22:24:27 +0000
> @@ -2003,6 +2003,29 @@
>    return val;
>  }

Could you describe the intention of the changes in alloc.c (basically,
provide ChangeLog entries)?

> +       doc: /* Compute A = B ^ C, bitwise exclusive or.

Why not make it C = A ^ B and then make C optional?
Same for other similar functions: make the destination argument optional.


        Stefan



  reply	other threads:[~2013-09-21  1:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 22:59 Set operations on bool-vectors Daniel Colascione
2013-09-21  1:57 ` Stefan Monnier [this message]
2013-09-21  2:44   ` Daniel Colascione
2013-09-21 15:51     ` Stefan Monnier
2013-09-21  2:26 ` Dmitry Antipov
2013-09-21  2:49   ` Daniel Colascione
2013-09-21  7:16     ` Eli Zaretskii
2013-09-21  7:43       ` Daniel Colascione
2013-09-21  7:36 ` Andreas Schwab
2013-09-21  7:38   ` Daniel Colascione
2013-09-21  8:35     ` Andreas Schwab
2013-09-21  8:49       ` Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8uyrc59w.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dancol@dancol.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.