From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16222: Installing ELPA packages complains about :keywords in define-package Date: Tue, 24 Dec 2013 11:23:10 -0500 Message-ID: References: <87r4938val.fsf@flea.lifelogs.com> <87lhzbfa4v.fsf@flea.lifelogs.com> <87mwjql699.fsf@flea.lifelogs.com> <8761qel1d3.fsf@flea.lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387902262 16194 80.91.229.3 (24 Dec 2013 16:24:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Dec 2013 16:24:22 +0000 (UTC) Cc: 16222@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 24 17:24:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VvUmL-0001r8-JM for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2013 17:24:21 +0100 Original-Received: from localhost ([::1]:39311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvUmK-0001to-Vv for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2013 11:24:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvUm9-0001nv-Uz for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 11:24:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvUm2-00087j-Lv for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 11:24:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvUm2-00087f-Il for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 11:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VvUm1-0004yM-V0 for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 11:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2013 16:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16222 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16222-submit@debbugs.gnu.org id=B16222.138790219819049 (code B ref 16222); Tue, 24 Dec 2013 16:24:01 +0000 Original-Received: (at 16222) by debbugs.gnu.org; 24 Dec 2013 16:23:18 +0000 Original-Received: from localhost ([127.0.0.1]:39274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvUlJ-0004x8-7F for submit@debbugs.gnu.org; Tue, 24 Dec 2013 11:23:17 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:57873) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvUlG-0004ww-Ql for 16222@debbugs.gnu.org; Tue, 24 Dec 2013 11:23:15 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBOGNAPk015913; Tue, 24 Dec 2013 11:23:11 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E1950AE086; Tue, 24 Dec 2013 11:23:10 -0500 (EST) In-Reply-To: <8761qel1d3.fsf@flea.lifelogs.com> (Ted Zlatanov's message of "Tue, 24 Dec 2013 10:23:04 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4802=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4802> : inlines <357> : streams <1096322> : uri <1633884> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82528 Archived-At: > 1) Why is *-pkg.el written in this bizarro syntax and not something that > compiles cleanly? Hysterical raisins! > IOW if it's going to be pure data, why pretend it's a funcall? > I'd rather rename it to *-pkg.data or something and eliminate any > chance of this problem recurring. The .el extension is wrong, > either way. If you ask me, the -autoloads.el and -pkg.el should be combined into a single file whose name is constant (i.e. does not include ). But that's a change in the format of ELPA packages, so it's a bit delicate to do: it will have to be done in steps (first add the new combined file in the packages, add support for it in package.el, then wait for everyone to start using the newer package.el, then start getting rid of the old redundant files). By the way, I didn't notice that the problem was introduced by the new ":keywords" argument, so we should change it so that its argument is quoted (so it works like a function call again). > (defun package--compile (pkg-desc) > "Byte-compile installed package PKG-DESC." > (package-activate-1 pkg-desc) > (byte-recompile-directory (package-desc-dir pkg-desc) 0 t)) Yes, this should skip the *-pkg.el files. Stefan