From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 16222@debbugs.gnu.org
Subject: bug#16222: Installing ELPA packages complains about :keywords in define-package
Date: Tue, 24 Dec 2013 11:23:10 -0500 [thread overview]
Message-ID: <jwv8uva1aup.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <8761qel1d3.fsf@flea.lifelogs.com> (Ted Zlatanov's message of "Tue, 24 Dec 2013 10:23:04 -0500")
> 1) Why is *-pkg.el written in this bizarro syntax and not something that
> compiles cleanly?
Hysterical raisins!
> IOW if it's going to be pure data, why pretend it's a funcall?
> I'd rather rename it to *-pkg.data or something and eliminate any
> chance of this problem recurring. The .el extension is wrong,
> either way.
If you ask me, the <foo>-autoloads.el and <foo>-pkg.el should be combined
into a single file whose name is constant (i.e. does not include <foo>).
But that's a change in the format of ELPA packages, so it's a bit
delicate to do: it will have to be done in steps (first add the new
combined file in the packages, add support for it in package.el, then
wait for everyone to start using the newer package.el, then start
getting rid of the old redundant files).
By the way, I didn't notice that the problem was introduced by the new
":keywords" argument, so we should change it so that its argument is
quoted (so it works like a function call again).
> (defun package--compile (pkg-desc)
> "Byte-compile installed package PKG-DESC."
> (package-activate-1 pkg-desc)
> (byte-recompile-directory (package-desc-dir pkg-desc) 0 t))
Yes, this should skip the *-pkg.el files.
Stefan
next prev parent reply other threads:[~2013-12-24 16:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 1:42 bug#16222: Installing ELPA packages complains about :keywords in define-package Juanma Barranquero
2013-12-23 15:02 ` Ted Zlatanov
2013-12-23 15:13 ` Juanma Barranquero
2013-12-23 22:57 ` Ted Zlatanov
2013-12-24 0:01 ` Juanma Barranquero
2013-12-24 3:43 ` Stefan Monnier
2013-12-24 13:37 ` Ted Zlatanov
2013-12-24 14:55 ` Stefan Monnier
2013-12-24 15:23 ` Ted Zlatanov
2013-12-24 16:23 ` Stefan Monnier [this message]
2014-01-15 5:02 ` Dmitry Gutov
2014-01-15 15:29 ` Stefan Monnier
2014-01-16 12:58 ` Dmitry Gutov
2014-01-16 16:18 ` Stefan Monnier
2014-01-16 17:04 ` Dmitry Gutov
2014-01-20 16:16 ` Ted Zlatanov
2014-01-21 1:58 ` Dmitry Gutov
2014-01-21 13:48 ` Stefan Monnier
2014-01-14 18:16 ` bug#16222: latest js2-mode from elpa causes backtrace during emacs initialization Tom Willis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8uva1aup.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=16222@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.