From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options. Date: Sun, 14 Dec 2014 18:36:18 -0500 Message-ID: References: <20141214114850.13638.56381@vcs.savannah.gnu.org> <877fxuxioc.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418600215 3973 80.91.229.3 (14 Dec 2014 23:36:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Dec 2014 23:36:55 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 15 00:36:48 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y0IiV-0002SX-S7 for ged-emacs-devel@m.gmane.org; Mon, 15 Dec 2014 00:36:48 +0100 Original-Received: from localhost ([::1]:37452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0IiV-0006GB-4j for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 18:36:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0IiA-0006FC-Md for emacs-devel@gnu.org; Sun, 14 Dec 2014 18:36:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0Ii3-0001jH-4q for emacs-devel@gnu.org; Sun, 14 Dec 2014 18:36:26 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:42853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Ii3-0001jB-18 for emacs-devel@gnu.org; Sun, 14 Dec 2014 18:36:19 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AskIAOwQflTO+ILA/2dsb2JhbABbgweDYMp3BAICgSQXAQEBAQEBfIQDAQEDAVYoCws0BwsUGA2IbgnWWQErkHYWhDIFiwGSMY9zggqBeII3gWIhgncBAQE X-IPAS-Result: AskIAOwQflTO+ILA/2dsb2JhbABbgweDYMp3BAICgSQXAQEBAQEBfIQDAQEDAVYoCws0BwsUGA2IbgnWWQErkHYWhDIFiwGSMY9zggqBeII3gWIhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="101723084" Original-Received: from 206-248-130-192.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Dec 2014 18:36:18 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 3CC9A25A8; Sun, 14 Dec 2014 18:36:18 -0500 (EST) In-Reply-To: <877fxuxioc.fsf@lifelogs.com> (Ted Zlatanov's message of "Sun, 14 Dec 2014 12:09:07 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180115 Archived-At: > FWIW, I think your version does not explain what the change provides, > only that it was made (it basically restates the diff). I don't know if > that's what you intended. The standard ChangeLog format is meant indeed to describe what the diff is intended to change in the code. The explanation of why we might want this change can be placed in the code (best choice when possible), or otherwise it can be placed just before the ChangeLog-formatted text (e.g. in the Summary line or right below it). Stefan