From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 68bcf86 2/4: package/names: :group can be given a list Date: Mon, 12 Jan 2015 10:21:34 -0500 Message-ID: References: <20150112112953.11913.47601@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421076129 6930 80.91.229.3 (12 Jan 2015 15:22:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 12 Jan 2015 15:22:09 +0000 (UTC) Cc: Artur Malabarba To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 12 16:22:03 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YAgoc-0007ZJ-UX for ged-emacs-devel@m.gmane.org; Mon, 12 Jan 2015 16:22:03 +0100 Original-Received: from localhost ([::1]:34689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAgoc-0001Vg-9X for ged-emacs-devel@m.gmane.org; Mon, 12 Jan 2015 10:22:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAgoF-00012B-Ic for emacs-devel@gnu.org; Mon, 12 Jan 2015 10:21:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAgoB-0005XU-1u for emacs-devel@gnu.org; Mon, 12 Jan 2015 10:21:39 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:29416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAgoA-0005XM-VV for emacs-devel@gnu.org; Mon, 12 Jan 2015 10:21:35 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjsPAOwQflS4rwoL/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQRWIxALNBIUGA2Id9ZZAQEBAQYBAQEBHpBvBxaEMgWLAYxVBZdUgXiEGSGCdwEBAQ X-IPAS-Result: AjsPAOwQflS4rwoL/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQRWIxALNBIUGA2Id9ZZAQEBAQYBAQEBHpBvBxaEMgWLAYxVBZdUgXiEGSGCdwEBAQ X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="107571379" Original-Received: from 184-175-10-11.dsl.teksavvy.com (HELO ceviche.home) ([184.175.10.11]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Jan 2015 10:21:34 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3E156660FB; Mon, 12 Jan 2015 10:21:34 -0500 (EST) In-Reply-To: (Artur Malabarba's message of "Mon, 12 Jan 2015 11:29:54 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181175 Archived-At: > '((:group > 1 (lambda (x) > - (if (symbolp x) > + (if (or (symbolp x) (listp x)) > (setq names--group-parent x) > (names--warn > "Argument given to :group is not a symbol: %s" x))) Just like we don't like '(lambda ...), we don't like '(... (lambda ...) ...) either (tho it's still found at many places in Emacs's source code since you can't "grep" for it quite as easily). Better use `(... ,(lambda ...) ...) instead, so the lambda is byte-compiled. Stefan