From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Artur Malabarba <bruce.connor.am@gmail.com>
Subject: Re: [elpa] master 68bcf86 2/4: package/names: :group can be given a list
Date: Mon, 12 Jan 2015 10:21:34 -0500 [thread overview]
Message-ID: <jwv8uh82fik.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1YAdBy-00037L-O2@vcs.savannah.gnu.org> (Artur Malabarba's message of "Mon, 12 Jan 2015 11:29:54 +0000")
> '((:group
> 1 (lambda (x)
> - (if (symbolp x)
> + (if (or (symbolp x) (listp x))
> (setq names--group-parent x)
> (names--warn
> "Argument given to :group is not a symbol: %s" x)))
Just like we don't like '(lambda ...), we don't like '(... (lambda ...)
...) either (tho it's still found at many places in Emacs's source code
since you can't "grep" for it quite as easily). Better use
`(... ,(lambda ...) ...) instead, so the lambda is byte-compiled.
Stefan
next parent reply other threads:[~2015-01-12 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150112112953.11913.47601@vcs.savannah.gnu.org>
[not found] ` <E1YAdBy-00037L-O2@vcs.savannah.gnu.org>
2015-01-12 15:21 ` Stefan Monnier [this message]
2015-01-12 16:11 ` [elpa] master 68bcf86 2/4: package/names: :group can be given a list Stephen J. Turnbull
2015-01-12 16:25 ` Nicolas Richard
2015-01-12 17:29 ` Stephen J. Turnbull
2015-01-12 18:13 ` David Kastrup
2015-01-12 20:30 ` Artur Malabarba
2015-01-12 21:41 ` David Kastrup
2015-01-13 5:53 ` Stephen J. Turnbull
2015-01-13 9:48 ` David Kastrup
2015-01-14 11:51 ` Artur Malabarba
2015-01-14 12:03 ` David Kastrup
2015-01-13 18:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8uh82fik.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.