From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20914: eieio/slot/group Date: Tue, 30 Jun 2015 14:09:20 -0400 Message-ID: References: <20150628.080243.1733196053784095862.devel@pollock-nageoire.net> <20150629.063137.1610262414319480638.devel@pollock-nageoire.net> <20150629.192952.75170699401312078.devel@pollock-nageoire.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1435687824 9126 80.91.229.3 (30 Jun 2015 18:10:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Jun 2015 18:10:24 +0000 (UTC) Cc: 20914@debbugs.gnu.org To: Pierre Lorenzon Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 30 20:10:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z9zz2-0006gw-MI for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jun 2015 20:10:12 +0200 Original-Received: from localhost ([::1]:48144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9zz2-0008Dt-1A for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jun 2015 14:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9zyx-0008Cp-W1 for bug-gnu-emacs@gnu.org; Tue, 30 Jun 2015 14:10:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9zyu-0006g8-Ng for bug-gnu-emacs@gnu.org; Tue, 30 Jun 2015 14:10:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9zyu-0006c2-Kv for bug-gnu-emacs@gnu.org; Tue, 30 Jun 2015 14:10:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z9zyt-0003HS-Ba for bug-gnu-emacs@gnu.org; Tue, 30 Jun 2015 14:10:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jun 2015 18:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20914-submit@debbugs.gnu.org id=B20914.143568776812561 (code B ref 20914); Tue, 30 Jun 2015 18:10:03 +0000 Original-Received: (at 20914) by debbugs.gnu.org; 30 Jun 2015 18:09:28 +0000 Original-Received: from localhost ([127.0.0.1]:34736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9zyK-0003GW-22 for submit@debbugs.gnu.org; Tue, 30 Jun 2015 14:09:28 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:61097) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9zyI-0003G0-DU for 20914@debbugs.gnu.org; Tue, 30 Jun 2015 14:09:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AsEwA731xV/2cGNJ1cgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBYtEqUAjhBQigngBAQE X-IPAS-Result: A0AsEwA731xV/2cGNJ1cgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBYtEqUAjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="128884841" Original-Received: from 157-52-6-103.cpe.teksavvy.com (HELO pastel.home) ([157.52.6.103]) by ironport2-out.teksavvy.com with ESMTP; 30 Jun 2015 14:09:20 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 739095FE1B; Tue, 30 Jun 2015 14:09:20 -0400 (EDT) In-Reply-To: <20150629.192952.75170699401312078.devel@pollock-nageoire.net> (Pierre Lorenzon's message of "Mon, 29 Jun 2015 19:29:52 +0200 (CEST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104541 Archived-At: > The problem comes from use of `copy-sequence' in > `eieio-copy-parents-into-subclass' function of eieio-core. this > copy is not reccursive as explained in code comment but it > should be ! There's a joined patch that fixes the bug. Thanks for the investigation. I think the fix should be applied deeper. Can you confirm that the patch below works for you as well? Stefan diff --git a/lisp/emacs-lisp/cl-preloaded.el b/lisp/emacs-lisp/cl-preloaded.el index ed0639b..2e9bdde 100644 --- a/lisp/emacs-lisp/cl-preloaded.el +++ b/lisp/emacs-lisp/cl-preloaded.el @@ -195,7 +195,7 @@ (:constructor nil) (:constructor cl--make-slot-descriptor (name &optional initform type props)) - (:copier cl--copy-slot-descriptor)) + (:copier nil)) ;; FIXME: This is actually not used yet, for circularity reasons! "Descriptor of structure slot." name ;Attribute name (symbol). @@ -205,6 +205,11 @@ ;; :documentation, :protection, :custom, :label, :group, :printer. (props nil :type alist)) +(defun cl--copy-slot-descriptor (slot) + (let ((new (copy-sequence slot))) + (cl-callf copy-sequence (cl--slot-descriptor-props new)) + new)) + (cl-defstruct (cl--class (:constructor nil) (:copier nil))