From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 326ffcc: Allow line comments ending with escaped NL to be continued to the next line. Date: Mon, 28 Dec 2015 11:14:36 -0500 Message-ID: References: <20151228160034.7510.58055@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451319318 23364 80.91.229.3 (28 Dec 2015 16:15:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 16:15:18 +0000 (UTC) Cc: Alan Mackenzie To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 28 17:15:02 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDaRq-0002r3-7h for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 17:15:02 +0100 Original-Received: from localhost ([::1]:44985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDaRp-0002fc-EN for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 11:15:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDaRa-0002fO-L7 for emacs-devel@gnu.org; Mon, 28 Dec 2015 11:14:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDaRW-0004aV-L1 for emacs-devel@gnu.org; Mon, 28 Dec 2015 11:14:46 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:35803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDaRW-0004Zx-FD for emacs-devel@gnu.org; Mon, 28 Dec 2015 11:14:42 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id tBSGEbf4015930; Mon, 28 Dec 2015 11:14:38 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id F168FAE069; Mon, 28 Dec 2015 11:14:36 -0500 (EST) In-Reply-To: (Alan Mackenzie's message of "Mon, 28 Dec 2015 16:00:35 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5533=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5533> : inlines <4158> : streams <1561604> : uri <2110030> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197010 Archived-At: > - /* Ignore escaped characters, except comment-enders. */ > - if (code != Sendcomment && char_quoted (from, from_byte)) > + /* Ignore escaped characters, except comment-enders which cannot > + be escaped. */ > + if ((Vcomment_end_can_be_escaped || code != Sendcomment) > + && char_quoted (from, from_byte)) [...] > if (code == Sendcomment > && SYNTAX_FLAGS_COMMENT_STYLE (syntax, 0) == style > && (SYNTAX_FLAGS_COMMENT_NESTED (syntax) ? > - (nesting > 0 && --nesting == 0) : nesting < 0)) > + (nesting > 0 && --nesting == 0) : nesting < 0) > + && !(Vcomment_end_can_be_escaped && char_quoted (from, from_byte))) Hmm... the way I read this, it would mean that /*blabla\*/ will be treated as an unclosed comment. Is that the way C defines it as well? Stefan