From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 c23c965: Prevent bootstrap autoload backup files Date: Tue, 12 Apr 2016 08:18:06 -0400 Message-ID: References: <20160412114621.17612.69908@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1460463534 9351 80.91.229.3 (12 Apr 2016 12:18:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Apr 2016 12:18:54 +0000 (UTC) Cc: Phillip Lord To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 12 14:18:45 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1apxHF-0002nN-UR for ged-emacs-devel@m.gmane.org; Tue, 12 Apr 2016 14:18:42 +0200 Original-Received: from localhost ([::1]:48291 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apxHF-0007xU-3u for ged-emacs-devel@m.gmane.org; Tue, 12 Apr 2016 08:18:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apxGn-0007pB-Fs for emacs-devel@gnu.org; Tue, 12 Apr 2016 08:18:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apxGh-0005RX-UG for emacs-devel@gnu.org; Tue, 12 Apr 2016 08:18:13 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:51951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apxGh-0005RD-Pz for emacs-devel@gnu.org; Tue, 12 Apr 2016 08:18:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CkCAA731xV/ySNSC1cgxCEAoVVwxECgT08EAEBAQEBAQGBCoQjAQEEeRALDScSFBiIcM8jAQEBAQYCAR+LOoQZbAcWhBcFpXWPDyOEFCKCeAEBAQ X-IPAS-Result: A0CkCAA731xV/ySNSC1cgxCEAoVVwxECgT08EAEBAQEBAQGBCoQjAQEEeRALDScSFBiIcM8jAQEBAQYCAR+LOoQZbAcWhBcFpXWPDyOEFCKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="206304288" Original-Received: from unknown (HELO pastel.home) ([45.72.141.36]) by ironport2-out.teksavvy.com with ESMTP; 12 Apr 2016 08:18:06 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8507F64276; Tue, 12 Apr 2016 08:18:06 -0400 (EDT) In-Reply-To: (Phillip Lord's message of "Tue, 12 Apr 2016 11:46:21 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202862 Archived-At: > - (let ((delay-mode-hooks t)) > - (find-file-noselect > - (autoload-ensure-default-file (autoload-generated-file)))))) > + (let* ((delay-mode-hooks t) > + (file (autoload-generated-file)) > + (file-missing (not (file-exists-p file)))) > + (when file-missing > + (autoload-ensure-default-file file)) > + (with-current-buffer > + (find-file-noselect > + (autoload-ensure-file-writeable > + file)) > + ;; block backups when the file has just been created, since > + ;; the backups will just be the auto-generated headers. > + ;; bug#23203 > + (when file-missing > + (setq buffer-backed-up t) > + (save-buffer)) > + (current-buffer))))) That looks quite complicated just to suppress backups. Could you explain why we couldn't just do something like: (let ((delay-mode-hooks t) (make-backup-files)) (find-file-noselect (autoload-ensure-default-file (autoload-generated-file)))))) or (let ((delay-mode-hooks t)) (with-current-buffer (find-file-noselect (autoload-ensure-default-file (autoload-generated-file))) (setq-local backup-inhibited t))))) -- Stefan