From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Gnu Elpa broken Date: Tue, 05 Sep 2017 09:14:06 -0400 Message-ID: References: <20170815220620.32748.5399@vcs0.savannah.gnu.org> <20170815220621.13CA220C81@vcs0.savannah.gnu.org> <87wp6479d8.fsf@ericabrahamsen.net> <878thttsqu.fsf_-_@drachen> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1504617856 12799 195.159.176.226 (5 Sep 2017 13:24:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Sep 2017 13:24:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eric Abrahamsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 05 15:23:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDpP-0001vV-WD for ged-emacs-devel@m.gmane.org; Tue, 05 Sep 2017 15:23:44 +0200 Original-Received: from localhost ([::1]:58924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpDpV-0006hc-Fm for ged-emacs-devel@m.gmane.org; Tue, 05 Sep 2017 09:23:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpDgq-0000Qy-AX for emacs-devel@gnu.org; Tue, 05 Sep 2017 09:14:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpDgl-0001Y6-KN for emacs-devel@gnu.org; Tue, 05 Sep 2017 09:14:52 -0400 Original-Received: from [195.159.176.226] (port=56394 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dpDgl-0001Wz-CS for emacs-devel@gnu.org; Tue, 05 Sep 2017 09:14:47 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dpDgJ-0005Wc-7R for emacs-devel@gnu.org; Tue, 05 Sep 2017 15:14:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 46 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:uPvurpu2loHl1feKYjGKbpB+qx0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217945 Archived-At: > seems GNU ELPA is broken since some days due to ebdb for me: "make" GNU ELPA (i.e. the archive distribution) is OK, but indeed the elpa.git checkout can't be directly built without error unless you have helm and pyim installed. I use the patch below locally for now. Haven't yet tried to push this to Eric. Stefan --- a/packages/ebdb-i18n-chn/ebdb-i18n-chn.el +++ b/packages/ebdb-i18n-chn/ebdb-i18n-chn.el @@ -1,4 +1,4 @@ -;;; ebdb-chn.el --- China-specific internationalization support for EBDB -*- lexical-binding: t; -*- +;;; ebdb-i18n-chn.el --- China-specific internationalization support for EBDB -*- lexical-binding: t; -*- ;; Copyright (C) 2016-2017 Free Software Foundation, Inc. @@ -33,7 +33,7 @@ ;;; Code: -(require 'pyim) +(when t (require 'pyim)) ;Don't require during compile-time. (require 'ebdb-i18n) (cl-defmethod ebdb-string-i18n ((phone ebdb-field-phone) diff --git a/packages/helm-ebdb/helm-ebdb.el b/packages/helm-ebdb/helm-ebdb.el index 63fda85f9..b160ca9e8 100644 --- a/packages/helm-ebdb/helm-ebdb.el +++ b/packages/helm-ebdb/helm-ebdb.el @@ -27,8 +27,8 @@ ;;; Code: -(require 'ebdb) -(require 'helm) +(require 'ebdb-com) +(when t (require 'helm)) ;Don't require during compile-time. (declare-function ebdb-display-records "ext:ebdb-com" (records &optional fmt append select pop buf))