From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: Re: Gnu Elpa broken
Date: Tue, 05 Sep 2017 09:14:06 -0400 [thread overview]
Message-ID: <jwv8thtnve3.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 878thttsqu.fsf_-_@drachen
> seems GNU ELPA is broken since some days due to ebdb for me: "make"
GNU ELPA (i.e. the archive distribution) is OK, but indeed the elpa.git
checkout can't be directly built without error unless you have helm and
pyim installed.
I use the patch below locally for now.
Haven't yet tried to push this to Eric.
Stefan
--- a/packages/ebdb-i18n-chn/ebdb-i18n-chn.el
+++ b/packages/ebdb-i18n-chn/ebdb-i18n-chn.el
@@ -1,4 +1,4 @@
-;;; ebdb-chn.el --- China-specific internationalization support for EBDB -*- lexical-binding: t; -*-
+;;; ebdb-i18n-chn.el --- China-specific internationalization support for EBDB -*- lexical-binding: t; -*-
;; Copyright (C) 2016-2017 Free Software Foundation, Inc.
@@ -33,7 +33,7 @@
;;; Code:
-(require 'pyim)
+(when t (require 'pyim)) ;Don't require during compile-time.
(require 'ebdb-i18n)
(cl-defmethod ebdb-string-i18n ((phone ebdb-field-phone)
diff --git a/packages/helm-ebdb/helm-ebdb.el b/packages/helm-ebdb/helm-ebdb.el
index 63fda85f9..b160ca9e8 100644
--- a/packages/helm-ebdb/helm-ebdb.el
+++ b/packages/helm-ebdb/helm-ebdb.el
@@ -27,8 +27,8 @@
;;; Code:
-(require 'ebdb)
-(require 'helm)
+(require 'ebdb-com)
+(when t (require 'helm)) ;Don't require during compile-time.
(declare-function ebdb-display-records "ext:ebdb-com"
(records &optional fmt append select pop buf))
next prev parent reply other threads:[~2017-09-05 13:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170815220620.32748.5399@vcs0.savannah.gnu.org>
[not found] ` <20170815220621.13CA220C81@vcs0.savannah.gnu.org>
2017-08-15 22:23 ` [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn Stefan Monnier
2017-08-15 22:29 ` Eric Abrahamsen
2017-08-21 18:04 ` João Távora
2017-08-22 22:57 ` Eric Abrahamsen
2017-09-05 9:11 ` Gnu Elpa broken (was: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn) Michael Heerdegen
2017-09-05 13:14 ` Stefan Monnier [this message]
2017-09-05 13:28 ` Gnu Elpa broken John Wiegley
2017-09-05 14:44 ` Michael Heerdegen
2017-09-05 15:39 ` Eric Abrahamsen
2017-09-05 16:12 ` Eric Abrahamsen
2017-09-05 21:57 ` Stefan Monnier
2017-09-05 22:18 ` Eric Abrahamsen
2017-09-05 22:28 ` Stefan Monnier
2017-09-06 11:27 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8thtnve3.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.