From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Sat, 20 Jan 2018 22:50:44 -0500 Message-ID: References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> <83bmhpt12i.fsf@gnu.org> <867escw93p.fsf@phe.ftfl.ca> <86vafwumqp.fsf@phe.ftfl.ca> <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516506577 29442 195.159.176.226 (21 Jan 2018 03:49:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Jan 2018 03:49:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Joseph Mingrone , Eli Zaretskii , ashish@FreeBSD.org, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 21 04:49:32 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed6d2-0005si-7o for ged-emacs-devel@m.gmane.org; Sun, 21 Jan 2018 04:49:08 +0100 Original-Received: from localhost ([::1]:57838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed6f2-0006mD-5a for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2018 22:51:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed6ew-0006lZ-5J for emacs-devel@gnu.org; Sat, 20 Jan 2018 22:51:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ed6et-0000Xf-3z for emacs-devel@gnu.org; Sat, 20 Jan 2018 22:51:06 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:38023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed6es-0000Vs-Uw; Sat, 20 Jan 2018 22:51:03 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w0L3oiOn021888; Sat, 20 Jan 2018 22:50:45 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 3E18F606D4; Sat, 20 Jan 2018 22:50:44 -0500 (EST) In-Reply-To: <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> (Paul Eggert's message of "Sat, 20 Jan 2018 19:41:32 -0800") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6204=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6204> : inlines <6323> : streams <1776640> : uri <2575771> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222120 Archived-At: > The problem occurs because (rename-file A B) signals an error if A has ACLs > and B's file system does not support ACLs. This is because rename-file calls > (copy-file A B nil t t t) and that last "t" tells copy-file to copy ACLs. Talking about what happens when rename-file uses copy-file: shouldn't it first copy-file to a temporary file near the destination and then rename-file that temp file? Otherwise the destination will temporarily be in a "partially written" state, which is usually not what `rename-file` callers want, right? Stefan