From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Glenn Morris <rgm@gnu.org>
Subject: Re: [Emacs-diffs] master d3437ea: Replace some obsolete functions in gnus
Date: Sat, 03 Mar 2018 23:56:25 -0500 [thread overview]
Message-ID: <jwv8tb8o2zq.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20180304011815.BD6F6207D1@vcs0.savannah.gnu.org> (Glenn Morris's message of "Sat, 3 Mar 2018 20:18:15 -0500 (EST)")
> (let ((passphrase
> - (password-read-and-add
> + (password-read
> "Passphrase for secret key (RET for no passphrase): " cache-key)))
> (if (string= passphrase "")
> nil
> + (and passphrase cache-key (password-cache-add cache-key passphrase))
> passphrase)))
Shouldn't we wait 'til we have confirmation that the password is correct
before calling password-cache-add?
Stefan
next parent reply other threads:[~2018-03-04 4:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180304011814.8826.18896@vcs0.savannah.gnu.org>
[not found] ` <20180304011815.BD6F6207D1@vcs0.savannah.gnu.org>
2018-03-04 4:56 ` Stefan Monnier [this message]
2018-03-05 18:38 ` [Emacs-diffs] master d3437ea: Replace some obsolete functions in gnus Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8tb8o2zq.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.