From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Thoughts on getting correct line numbers in the byte compiler's warning messages Date: Mon, 12 Nov 2018 15:36:14 -0500 Message-ID: References: <20181105105302.GA10520@ACM> <20181106151143.GB4030@ACM> <20181107170036.GA4934@ACM> <20181107184708.GB4934@ACM> <20181108140843.GB5041@ACM> <20181112154448.GB4459@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1542054889 20093 195.159.176.226 (12 Nov 2018 20:34:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Nov 2018 20:34:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Michael Heerdegen , Eli Zaretskii , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 12 21:34:44 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMIuy-00056Z-Cx for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2018 21:34:44 +0100 Original-Received: from localhost ([::1]:50561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMIx4-0003vz-I3 for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2018 15:36:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMIwx-0003vf-Ke for emacs-devel@gnu.org; Mon, 12 Nov 2018 15:36:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMIww-0000c1-RJ for emacs-devel@gnu.org; Mon, 12 Nov 2018 15:36:47 -0500 Original-Received: from alt22.smtp-out.videotron.ca ([70.80.0.73]:29631) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gMIwu-0000RK-Ej for emacs-devel@gnu.org; Mon, 12 Nov 2018 15:36:44 -0500 Original-Received: from fmsmemgm.homelinux.net ([24.48.32.163]) by Videotron with SMTP id MIwRgzPtnELtdMIwSguTHT; Mon, 12 Nov 2018 15:36:17 -0500 X-Authority-Analysis: v=2.3 cv=atGc9xRV c=1 sm=1 tr=0 a=FFH0pMpobpdI/IS5PdLu1w==:117 a=FFH0pMpobpdI/IS5PdLu1w==:17 a=JHtHm7312UAA:10 a=7Z8NNAahZfoBz3HjyoMA:9 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E5B7EAE1F8; Mon, 12 Nov 2018 15:36:14 -0500 (EST) In-Reply-To: <20181112154448.GB4459@ACM> (Alan Mackenzie's message of "Mon, 12 Nov 2018 15:44:48 +0000") X-CMAE-Envelope: MS4wfEpD9gRvNMbNz9KcQkXBWAZQo3fibaDftvKLC7gKu9RjgUcXj6kH04iHg4RRvpRd2TSfSgglZ0VGxlls6onMYIhA/m4hMXn/hq/ag6QWbrK+UIk00hAq T2Hf/Vy+hA3Qood1GZSffW0rYd8ePe3p0snm5z3R5OXwNTLCHJRbLKIEv3YiRBMDin2Z7cXCz+1uSJjoxYzwZ8tc5PJoxzWYk9dczM3IDGMxfM2hA6Jcugef 5X6yHtD6NsJJj+G5GmqhBW4+XrjjcUppy7yGhhcikdAPpy9r/3Ioi/Q39jywglPX X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 70.80.0.73 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231103 Archived-At: > Unfortunately, this isn't going to work. There will be macros which do > things like: > > (cond ((eq (car form) 'bar) ....) .....) > > Here, (car form) is going to be #, so the eq is going > to return nil. [...] > This isn't pretty. If this modification of eq, memq, .... is too much > to take, then I think the current approach is doomed to failure. It's indeed a serious concern. Maybe we can circumvent by changing those pieces of code to use `eql` (and make sure `eql` consider a symbol and its symbol-with-pos as equal, obviously). Changing `eq` would better be avoided, Stefan