From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#35739: Bad signature from GNU ELPA Date: Wed, 22 May 2019 12:20:01 -0400 Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255090"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 22 18:21:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTTzP-00147k-K1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 18:21:15 +0200 Original-Received: from localhost ([127.0.0.1]:47452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTTzO-0004MG-EY for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 12:21:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTTzD-0004Ld-RW for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 12:21:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTTzC-0001Fh-P8 for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 12:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57455) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTTzC-0001ER-2u for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 12:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTTzB-0008Kv-S3 for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 12:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2019 16:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35739 X-GNU-PR-Package: emacs Original-Received: via spool by 35739-submit@debbugs.gnu.org id=B35739.155854201331950 (code B ref 35739); Wed, 22 May 2019 16:21:01 +0000 Original-Received: (at 35739) by debbugs.gnu.org; 22 May 2019 16:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:42765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTTyO-0008JG-Sf for submit@debbugs.gnu.org; Wed, 22 May 2019 12:20:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTTyN-0008J1-Eg for 35739@debbugs.gnu.org; Wed, 22 May 2019 12:20:12 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2017B100DB7; Wed, 22 May 2019 12:20:06 -0400 (EDT) Original-Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0C0E3100A32; Wed, 22 May 2019 12:20:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558542004; bh=e4o1P7+73obNemirALS6Va7tp/Ab3ssOo3bqbTll9eU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lXGkO1LcopYUCCeoFM7IyFSGG6a/UAm1/j5JCNdOpWp4jHj4fe5/ibbhHGog8EwAO 0vRNebPlf6ksxre0oTC/JgDOD2ilyN25Gna5JdEcpsmmq4Vxlxt0hSodLAPKFaNLXP eaDXXKHrPUSZnW4EONufB7C5QUVEVMbQH5GRAVCz/bSma0fcN+ffgtBA0nwCVo5zuc KBPmEMCm+l1h9/6lN+R3DY6qmOcSUVGxXTTpThuhCN4pDNqeHqwg3iGKNIxxaweF6r rEmXDrL0IrdBwOn6V6pYJB7RNgqSSh9bllVgLir6GnRtPq/Hbze5YWJRUPweit6IXo NYoRPxlt+Bdog== Original-Received: from alfajor (unknown [216.154.3.168]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 8B099120ABE; Wed, 22 May 2019 12:20:03 -0400 (EDT) In-Reply-To: <83o93v83si.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 May 2019 08:19:09 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159655 Archived-At: > I don't think I understand the change enough to say something > intelligent here. The commit explains, o some extent, why the > original code failed, but it says nothing about the way the new code > solves the problem without introducing new ones. It solves the problem by refraining from decoding until we know positively that it needs to happen. In the patch I installed, I only end up decoding the readme.txt descriptions. Maybe there are other places where decoding is needed, if so we'll need to fix those cases I missed when we find them. > I'm also mildly worried about the incompatible change in url-insert, > which is a general-purpose function not limited to package.el and its > signature verification. Yes, this part should definitely not be in emacs-26. Luckily, I think the rest of the change still solves our problem in practice in Emacs-26 (the change in url-insert only affects the case where the HTTP headers returned by the server specify a particular "charset", which is not the case when downloading .tar and .el files from elpa.gnu.org AFAICT). Stefan