all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: 39842@debbugs.gnu.org
Subject: bug#39842: [PATCH] Use help-fns-short-filename in other describe- commands
Date: Sat, 29 Feb 2020 15:02:05 -0500	[thread overview]
Message-ID: <jwv8skl5fu7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200229190008.338460-1-stepnem@gmail.com> ("Štěpán Němec"'s message of "Sat, 29 Feb 2020 20:00:08 +0100")

> Make the other help commands use it, too.

Sounds good.  See a few comments below.

> +;;;###autoload
>  (defun help-fns-short-filename (filename)

OK, we can live that.  Maybe, moving it to help.el would be a cleaner option.

> index 45cbaad4e8..32204d04e3 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -879,6 +879,7 @@ describe-key
>              (princ ", which is ")
>  	    (describe-function-1 defn)))))))
>  \f
> +(declare-function help-fns-short-filename "help-fns" (filename))
>  (defun describe-mode (&optional buffer)
>    "Display documentation of current major mode and minor modes.
>  A brief summary of the minor modes comes first, followed by the

The autoload cookie above should render this `declare-function`
unnecessary, right?


        Stefan






  reply	other threads:[~2020-02-29 20:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-29 19:00 bug#39842: [PATCH] Use help-fns-short-filename in other describe- commands Štěpán Němec
2020-02-29 20:02 ` Stefan Monnier [this message]
2020-02-29 20:18   ` Štěpán Němec
2020-02-29 20:29     ` Stefan Monnier
2020-02-29 20:40       ` Štěpán Němec
2020-02-29 21:07         ` Stefan Monnier
2020-02-29 21:47           ` Štěpán Němec
2020-03-03 15:53             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8skl5fu7.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=39842@debbugs.gnu.org \
    --cc=stepnem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.