all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119)
Date: Wed, 25 Mar 2020 23:42:39 -0400	[thread overview]
Message-ID: <jwv8sjn4wmc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AA720D82-0063-4A0E-81A8-B3F4C8E7A979@acm.org> ("Mattias Engdegård"'s message of "Wed, 25 Mar 2020 23:29:50 +0100")

>> The regular expressions are written either with or without case-folding
>> in mind, so changing it globally is a recipe for problems.
> Agreed, but I doubt that anyone will ever set the option.

Then let's make it into a simple `defvar` rather than a defcustom and
make the docstring clarify that it's only useful for temporary
backward compatibility.

>> PS: The same applies to the "zero/one-based column numbers" and
>>    the "char-colums vs visual-columns vs byte-columns", admittedly.
>
> Yes, those settings would make more sense if they were rule-specific.
> Still, actual examples of tools needing them would be useful.

In sml-mode.el (GNU ELPA) I set `compilation-error-screen-columns`
buffer-locally but it really should be rule-local.  In tuareg-mode (not
in GNU ELPA, sadly), I set both `compilation-first-column` and
`compilation-error-screen-columns` buffer-locally for the same reason.


        Stefan




  reply	other threads:[~2020-03-26  3:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200325204155.5002.75177@vcs0.savannah.gnu.org>
     [not found] ` <20200325204157.3643820E43@vcs0.savannah.gnu.org>
2020-03-25 20:54   ` master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119) Stefan Monnier
2020-03-25 22:29     ` Mattias Engdegård
2020-03-26  3:42       ` Stefan Monnier [this message]
2020-03-26 16:25         ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8sjn4wmc.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.