From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bug#30854: 27.0.50; Speeding up package.el startup Date: Fri, 18 Dec 2020 10:02:31 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6296"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: arthur.miller@live.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 18 16:04:19 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqHIp-0001VN-Fe for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Dec 2020 16:04:19 +0100 Original-Received: from localhost ([::1]:54436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqHIo-0004sL-G1 for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Dec 2020 10:04:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqHHB-0003ZE-Uq for emacs-devel@gnu.org; Fri, 18 Dec 2020 10:02:37 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqHHA-0001WU-1L for emacs-devel@gnu.org; Fri, 18 Dec 2020 10:02:37 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CCC2D100236; Fri, 18 Dec 2020 10:02:34 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 28D08100250; Fri, 18 Dec 2020 10:02:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608303753; bh=epcRx+0nNSg1Z3m6k4JVCJuHvlyMIeZyGxOxINP5a+U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=T3NthdvB5sj4z+hOwASMxk75pjwoIQK5rGG/spVk5iiGpufNS6NxOCE2lsvbCXv/Y WJSz9btd6ZeE9XS+0NrZ9TQdHncC0A+Zgz7BGZIdHwjOImw7/W5zO/UbwHjIWgTNgl s0QChA6l0745onMsQ9VLUEvnNmuCyCIEp6fKc9+8M2H7DiBrCIj/VkBT1A5ak6TEpt Q7pxIrxX5nx8qoZCYgnOui5/BlmD7jOzSL7yVtq5isqXhA8XqpauFofTchx+2EWO3y jisOazDbuaRvOHRUnBWMxqXq5EIMhJJYJxMqepdjfTNGgZZAdQPPQIrG4WZbocCamI xvg4IkWpbd0hw== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D1D9E120281; Fri, 18 Dec 2020 10:02:32 -0500 (EST) In-Reply-To: (arthur miller's message of "Fri, 18 Dec 2020 11:56:11 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261193 Archived-At: >> We could speed it up even further by byte-compiling this file, but this >> has bumped into some corner cases problems so I'm sticking to >> a non-compiled file for now. > Which corner cases apply to this? If it is OK to ask you? [ You quoted a lot of text, so I'm not completely sure, but `C-s` seemed to indicate that you were referring to just those above three lines I kept. ] I can't remember off-hand. Actually, I have a vague recollection that the problems turned out having some other origin. So indeed we should byte-compile the resulting file. > compiling and baking package-quickstart.el into my init file (with > disabled package-quickstart). I don't know what this means. > I have also optimized it slightly: every autoload file adds it's own > path to load-path via add-to-list at startup time. But all those paths > are known when package-quickstart-refresh runs, so we can simply > concatenate them to one list and then emit code to just nconc emitted > that list to load-path at startup (this is what I do in my init file). I'm surprised a single call to `nconc` would be noticeably faster than a hundred calls to `add-to-list`. I mean, obviously it's a lot faster, but unless you do that in a loop (which is not the case here), I wouldn't expect the difference to be measurable. Stefan