From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#45345: [elpa-archive] "make build/" should not pull unconditionally Date: Mon, 21 Dec 2020 09:33:20 -0500 Message-ID: References: <875z4wi5i6.fsf@bernoul.li> <87ft3zbfmh.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3675"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45345@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 21 15:34:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krMGI-0000px-IW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 15:34:10 +0100 Original-Received: from localhost ([::1]:59974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krMGH-0000lN-Jy for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 09:34:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krMGA-0000lG-E8 for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 09:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35073) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krMGA-0003bw-6p for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 09:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krMGA-0001Pb-3p for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 09:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Dec 2020 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45345 X-GNU-PR-Package: emacs Original-Received: via spool by 45345-submit@debbugs.gnu.org id=B45345.16085612145323 (code B ref 45345); Mon, 21 Dec 2020 14:34:02 +0000 Original-Received: (at 45345) by debbugs.gnu.org; 21 Dec 2020 14:33:34 +0000 Original-Received: from localhost ([127.0.0.1]:46619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krMFh-0001Nl-Sn for submit@debbugs.gnu.org; Mon, 21 Dec 2020 09:33:34 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krMFc-0001Mx-Cd for 45345@debbugs.gnu.org; Mon, 21 Dec 2020 09:33:32 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D1120100246; Mon, 21 Dec 2020 09:33:22 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 602BE100068; Mon, 21 Dec 2020 09:33:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608561201; bh=1YmkkkxllJ45Pqfl/SXay82AzcYa39fm/jg3qR7BO2U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Vz4jNC2i0KXT6O3UnI1lPTQThsjEgCaE/lh1TQhuHeZo8ehvz5Xxm9jstFY6FPybL xq5bDsjNQAXc10QrgN24HGbJtm3LBsSxvzh7fIRo+E7/ioiQp8rprU9DEoxoX4Y43v VpD6qtnwFVRQGxOnXgnleR+q6DbtA63x1BjixjumlB+pUlghfnKiH4qin0cx+Z65Sb W+OS2SXQ0LxiSqlLCAo0woRct7mb8eogWKt3R1axed3AXjQPff8fK/s85MarU1MhqY xhYeI8NyCiTSVgGqur4PPapfghyQFy2oYZ5FTHjFVnvlc97hpWQss8yVvnh2Xl2ieO yajM9BCEBrBmQ== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 32525120312; Mon, 21 Dec 2020 09:33:21 -0500 (EST) In-Reply-To: <87ft3zbfmh.fsf@bernoul.li> (Jonas Bernoulli's message of "Mon, 21 Dec 2020 11:47:02 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196535 Archived-At: > I was making some experimental changes. In this case the changes where > to transient's internal tools responsible for updating version numbers > in the manual. These tools are broken when used in a worktree of the > elpa repository because they relay in git tags, which do not exist here. > > I did not want to push any of these very temporary experiments to the > public transient repository, just so elpa-archive could pull them from > there. There's definitely no need to affect remote repositories. Assuming you're using the "normal" setup where `packages/transient` is a worktree, `elpaa--external-package-sync` won't actually fetch anything from the remote server and will just do `git merge` which will presumably do nothing at all unless you've `git fetched` something into `origin/externals/transient` since the last sync or you manually moved the `externals/transient` branch back to some earlier commit. So, I think your diagnostic pointing at `elpaa--external-package-sync` was a red herring and the problem is rather that: >> `elpaa--make-one-package' >> is supposed to make packages from *commits* whereas you wanted to make a tarball from whatever was currently in `packages/transient`, including uncommitted changes. Is that right? IOW the function that got in the way of your goal wasn't `elpaa--external-package-sync` but `elpaa--clean`. I think the solution will be to make a new kind of make target which just builds one tarball and skips `elpaa--clean` (and will also skip `elpaa--external-package-sync` while we're at it). Stefan