From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53227: master: Wrong error message with M-: (funcall). Date: Thu, 13 Jan 2022 19:09:43 -0500 Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> <87lezj2nds.fsf@igel.home> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6615"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 14 01:10:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8AAi-0001V2-FH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 01:10:24 +0100 Original-Received: from localhost ([::1]:33680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8AAg-0001dF-DX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 19:10:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8AAM-0001d5-8k for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 19:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8AAL-0002jf-VM for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 19:10:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8AAL-000240-Ja for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 19:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jan 2022 00:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53227 X-GNU-PR-Package: emacs Original-Received: via spool by 53227-submit@debbugs.gnu.org id=B53227.16421189967914 (code B ref 53227); Fri, 14 Jan 2022 00:10:01 +0000 Original-Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 00:09:56 +0000 Original-Received: from localhost ([127.0.0.1]:34866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8AAG-00023a-8g for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:09:56 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8AAE-00023J-0a for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 19:09:54 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0AFF41001AC; Thu, 13 Jan 2022 19:09:48 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3CB3710018A; Thu, 13 Jan 2022 19:09:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642118986; bh=MmLkjGHCdu9NubT23iL9HNFREHztK4QHpv0EcoGwIrk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FV12eJ3If/ITIvzf3BfwkwK280O7KXPfa1ohWOBicE3L2/4CLOUg10hOn5cfEix6R 82Lb8K/OIZejX23QqM5Thl88Y0ivr9Jh47tAeCOiFi+WlzN5B/V7wCD7cgXG3WWjLT 5rrYSYxVykdSwk47bAMuoiR+6pgKuesjpXuH5vUOYTN4JMJ4BpttZSAgbKR6H+rBcr a4zKKh4NmN2KEinCouLo4vWsNHVwDPgij+CjXvd5SmWVDGYxxPrpT9VnCWtuNbh6aB PrBoAZ0Omp8zVGTeUqDPKJcITCzRPlY8q/JfnG6FZXvyelBh3C2A9+MDAiafP8UMs4 5QGl39dC1MNvg== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EC8431203CD; Thu, 13 Jan 2022 19:09:45 -0500 (EST) In-Reply-To: <87lezj2nds.fsf@igel.home> (Andreas Schwab's message of "Fri, 14 Jan 2022 01:04:47 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224144 Archived-At: Andreas Schwab [2022-01-14 01:04:47] wrote: > On Jan 13 2022, Stefan Monnier wrote: >>> Why do you need the second pattern? >> The second pattern should let `pcase` generate better code. > But it is not needed for this bug. The actual fix is in the change from (`(funcall . ,(or `(,exp . ,args) pcase--dontcare)) to (`(funcall ,exp . ,args) which makes the pattern not match `(funcall . ,_) any more. The explicit (`(funcall . ,_) form) ;bug#53227 is then present to make sure the first change doesn't worsen the rest of the resulting macroexpanded code. Stefan