From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: undo-auto--undoable-change infloop Date: Fri, 05 Aug 2022 10:42:54 -0400 Message-ID: References: <87o7xc1qbh.fsf@web.de> <831qu8dqrx.fsf@gnu.org> <87bktbciup.fsf@web.de> <875yjfo105.fsf@web.de> <87fsii0vvp.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15924"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 05 16:45:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJyZP-0003sL-RH for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Aug 2022 16:45:00 +0200 Original-Received: from localhost ([::1]:46178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJyZO-0001be-Uq for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Aug 2022 10:44:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJyXY-0007kH-4T for emacs-devel@gnu.org; Fri, 05 Aug 2022 10:43:04 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJyXU-0001DZ-P5; Fri, 05 Aug 2022 10:43:03 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A75BC100124; Fri, 5 Aug 2022 10:42:58 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3DF0F10010C; Fri, 5 Aug 2022 10:42:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1659710577; bh=dO43+uFwxfTvywyFFugucCGAhH9f07ZKBwOEk41b7oo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MmxBKQX1ovb4T46zkHLIeTbKJrQpg/lzfyJN58ztjhamS9TST5PRXaVuv8cTISyui 9RkuU4XqZpocoW3bU3g4KoasxOCjZjPNySt3rMoGk73be+0jb2HagI1CAxpjcpytEf YcmNBcrcmh5+fuyUg8gyn4iTbaGUQBpdBXBXj0cKeLBQDrHuNo1rFRrAZ/KmoGzqtu 8nZNRaAvUQrlVVyALCMMDPVANyHzmpTslsOnPizrpnuffEEoYkrFASd67km6xXbM3v gikcCZNSGGStlwYKHZsYrSjyrXbuiBDuOkUtqyWBVRso5V3jbI1B+/2LZGc85C2rnJ lezZ0Qq/PGwmw== Original-Received: from milanesa (net-5-89-24-238.cust.vodafonedsl.it [5.89.24.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5B34712046B; Fri, 5 Aug 2022 10:42:56 -0400 (EDT) In-Reply-To: <87fsii0vvp.fsf@web.de> (Michael Heerdegen's message of "Sun, 31 Jul 2022 06:05:46 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293118 Archived-At: > I found something in a different place of my code. That code uses > `timer-activate', but `timer-activate' doesn't check whether the timer > is already in the timer list, and that caused the duplicates I think. I > didn't expect it to not check that. Maybe that's the whole story > already. I suspect that `timer-activate` was not intended to be used by end-users, but in any case I added a check that signals an error if you try to re-add a timer. [ It would have been better to report this as a bug, so we'd have a bug-number to refer to. ] Stefan