From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 18:19:57 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83351o9m6h.fsf@gnu.org> <87ilakgmjo.fsf@localhost> <83pm4r9apt.fsf@gnu.org> <83mszv93yb.fsf@gnu.org> <83edl78yly.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40956"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 00:21:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLA7F-000ASS-3X for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 00:21:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLA6y-0003J5-8P; Sun, 16 Jul 2023 18:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLA6w-0003Ix-Uf for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 18:21:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLA6w-0007aj-M7 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 18:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLA6w-0006jm-D9 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 18:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168954600725825 (code B ref 64596); Sun, 16 Jul 2023 22:21:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 22:20:07 +0000 Original-Received: from localhost ([127.0.0.1]:48714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLA63-0006iQ-3w for submit@debbugs.gnu.org; Sun, 16 Jul 2023 18:20:07 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLA60-0006hn-QN for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 18:20:06 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 86C981000C4; Sun, 16 Jul 2023 18:19:59 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 96E09100097; Sun, 16 Jul 2023 18:19:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689545998; bh=LfJ/rb0myeZg6oAhsDPyxICFqd79PENcJ9RuaI/V8Dc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GINk6S3Q5kuw598mudQo4pomFfqkuoP5nlifgXIdQynzfj9qioizXb4rO/KJkFelz 5p+tuvhhBax3ig/h65JcwdC4xrGEJKbyHpH0oYxT/qdk00p7s8dxhr+Rs8l6vrQ4DQ 3Cey54oFOXp2HE0cm+C1GtA+hOkIWqu1YmOTqS7V4FmWtQEOoCHqHzyGQrVUrmmjQ/ 0nbJnu/le4B7PWKbHZKlF/4jKD+vO93i9fHirZ3em9c+Fd8yIaAvoQY9SAbUxCWExs g/9HzOamrUlI7ct9IMWD8FPm0U2PWblyXuomaE234AQkKMmT0vuA0yFGWtJmB7GSPX +axCr9Ro/6rMQ== Original-Received: from pastel (unknown [108.175.226.218]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 68A101202B9; Sun, 16 Jul 2023 18:19:58 -0400 (EDT) In-Reply-To: <83edl78yly.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Jul 2023 22:06:49 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265363 Archived-At: > That's not all of the uses of this flag. Here's one example of other > uses: > > if (some_windows > && !f->redisplay > && !w->redisplay > && !XBUFFER (w->contents)->text->redisplay) > continue; > > (This avoids updating the tool bar and the tab bar of the frame, and > there's a similar condition that avoids updating the frame's title.) Right, but notice that what we're fundamentally checking is whether `w` (which is the frame's selected window here) needs to be updated, because that's the one currently "occupying" the tool-bar. FWIW, I don't know why we don't also check `XBUFFER(w->contents)->redisplay` here. Also, I still don't see why that makes you think: frame's redisplay flag is what causes us to consider a frame in the first place. Indeed, a frame's redisplay flag may be such a reason, but a window's flag or its text buffer's may be the reason instead. A frame's `redisplay` flag does not need to be set for us to consider it. Stefan