From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67210: 30.0.50; completing-read with REQUIRE-MATCH=t can sometimes return a non-match Date: Fri, 17 Nov 2023 11:06:09 -0500 Message-ID: References: <8334x6qmu7.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5008"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 67210@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 17 17:09:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r41PP-00017v-RS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Nov 2023 17:09:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r41Oz-0001xO-8q; Fri, 17 Nov 2023 11:09:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r41Ow-0001xG-CP for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 11:09:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r41Ow-0007TA-3q for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 11:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r41Ov-0004vt-W2 for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 11:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Nov 2023 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67210 X-GNU-PR-Package: emacs Original-Received: via spool by 67210-submit@debbugs.gnu.org id=B67210.170023733318946 (code B ref 67210); Fri, 17 Nov 2023 16:09:01 +0000 Original-Received: (at 67210) by debbugs.gnu.org; 17 Nov 2023 16:08:53 +0000 Original-Received: from localhost ([127.0.0.1]:47021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r41On-0004vV-5a for submit@debbugs.gnu.org; Fri, 17 Nov 2023 11:08:53 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r41Oi-0004v9-1r for 67210@debbugs.gnu.org; Fri, 17 Nov 2023 11:08:51 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 52E4C1000BC; Fri, 17 Nov 2023 11:08:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700237321; bh=xGNcbVFy9PwTvfg2qSh7bMVvlOx4aNDWfkxvFmDS/LY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=N658SbE3t+gqioX4OPaV51qb5NfBnyWG63xtG2IsbcWLpvzwrg1OcUr12m0VMjx9M nCN1e7z5QNV2L6Q77ImuRg6OIVqMnm8GFXkMz4aoWRtx1FJhWASQcA9/uknFxxNeCh 7Aj0wTTrVWkpMR1xsCS3kX+XsIBX7YNvFIgwpG8mIB4GS/wnkvjusAdgnJRjw6S2fV L1zV6BHjDEPzS4PzLGGrSTrvVslXwuMBsEeJJd2OWTYrhtaKGR1UDqoOzDQJ0X/KlK T9thDXVgqot/c9B/cudgWT8XXiMiEcAIUkK/f4Tc1DMHzUOOV6fQndPw/1HOofZlHl 6Mlnma98mGSjQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A5E22100061; Fri, 17 Nov 2023 11:08:41 -0500 (EST) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 946E31202E0; Fri, 17 Nov 2023 11:08:41 -0500 (EST) In-Reply-To: (Spencer Baugh's message of "Thu, 16 Nov 2023 11:36:57 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274506 Archived-At: > (defun completion-emacs22-try-completion (string table pred point) > (let ((suffix (substring string point)) > (completion (try-completion (substring string 0 point) table pred))) > - (if (not (stringp completion)) > - completion > + (cond > + ((eq completion t) > + ;; The prefix is an exact and unique completion, but STRING > + ;; might not be a completion. > + (if (test-completion string table) > + t > + (cons string point))) I think we should test (equal "" suffix) instead. The cases where (equal "" suffix) is false but (test-completion string table) are sufficiently weird that returning t seems risky and I can't think of any reason why it's worthwhile to take this risk. Stefan