From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 67210@debbugs.gnu.org
Subject: bug#67210: 30.0.50; completing-read with REQUIRE-MATCH=t can sometimes return a non-match
Date: Fri, 17 Nov 2023 11:06:09 -0500 [thread overview]
Message-ID: <jwv8r6w1i6k.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <ierv8a1iriu.fsf@janestreet.com> (Spencer Baugh's message of "Thu, 16 Nov 2023 11:36:57 -0500")
> (defun completion-emacs22-try-completion (string table pred point)
> (let ((suffix (substring string point))
> (completion (try-completion (substring string 0 point) table pred)))
> - (if (not (stringp completion))
> - completion
> + (cond
> + ((eq completion t)
> + ;; The prefix is an exact and unique completion, but STRING
> + ;; might not be a completion.
> + (if (test-completion string table)
> + t
> + (cons string point)))
I think we should test (equal "" suffix) instead.
The cases where (equal "" suffix) is false but (test-completion string table)
are sufficiently weird that returning t seems risky and I can't think of
any reason why it's worthwhile to take this risk.
Stefan
next prev parent reply other threads:[~2023-11-17 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 20:25 bug#67210: 30.0.50; completing-read with REQUIRE-MATCH=t can sometimes return a non-match Spencer Baugh
2023-11-16 1:29 ` Drew Adams
2023-11-16 14:47 ` Spencer Baugh
2023-11-16 17:13 ` Drew Adams
2023-11-16 5:38 ` Eli Zaretskii
2023-11-16 15:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 16:36 ` Spencer Baugh
2023-11-16 18:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-17 16:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-17 17:18 ` Spencer Baugh
2023-11-17 17:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8r6w1i6k.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=67210@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.