From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68690: Segmentation fault building with native-comp Date: Thu, 25 Jan 2024 10:58:03 -0500 Message-ID: References: <87wmryel78.fsf@pub.pink> <86zfwud5cv.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2052"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eliz@gnu.org, jm@pub.pink, 68690@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 25 16:59:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rT28H-0000Kk-Co for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jan 2024 16:59:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rT284-0003OM-Jq; Thu, 25 Jan 2024 10:59:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT281-0003Nx-7e for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 10:58:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rT280-000459-Lt for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 10:58:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rT286-0006wj-5z for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 10:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68690 X-GNU-PR-Package: emacs Original-Received: via spool by 68690-submit@debbugs.gnu.org id=B68690.170619829926653 (code B ref 68690); Thu, 25 Jan 2024 15:59:02 +0000 Original-Received: (at 68690) by debbugs.gnu.org; 25 Jan 2024 15:58:19 +0000 Original-Received: from localhost ([127.0.0.1]:48933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT27P-0006vp-1q for submit@debbugs.gnu.org; Thu, 25 Jan 2024 10:58:19 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT27N-0006va-0s for 68690@debbugs.gnu.org; Thu, 25 Jan 2024 10:58:17 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B8BFA4427F1; Thu, 25 Jan 2024 10:58:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706198284; bh=dlqjgGS1Asf1GF8eyI3fV+JKT4iA4dORjgwbmSFmYds=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=mticxHDMmk8LmF8ggrQ+d5a5wdCfDG0fgwV43FoqToFqIoO/ovqcEMhTYQ7lbY3fx tOOfiTbdmsEf8vinGjQS7vg43mODTlWzyXc5UOP+Xt8VMGOxn0XA3xqbKmtIZrW2Bi 9jFvZzunGHfEp7lanTydhIuYI4RBkuAISbwcSqJgjAfg8M5mOlI0qQTlL/xqAlWaAj 7/HwCxg+mpDvquMJU5y+EPGGpFs8ryGGD8CaOW9CEgXLqhSGkjWfHLnBKnTvZrpcs/ okhyshsHFhleEDiwOgm0vsqXWdzepG1o1xVN+1h5bOU1WjT+iqZWREzNSsktxbx8Z/ 5qb//FeHWcmiA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 94C2B4427E6; Thu, 25 Jan 2024 10:58:04 -0500 (EST) Original-Received: from pastel (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 673091208CC; Thu, 25 Jan 2024 10:58:04 -0500 (EST) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Thu, 25 Jan 2024 09:33:45 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278861 Archived-At: >> I wonder if a puthash while being in a DOHASH (which is the ASAN failure >> I showed) is something we should pursue. I don't think that's something >> that's guaranteed to work in a meaningful way. WDYT? The original DOHASH's comment indeed said it didn't support that operation, yet the code used DOHASH to implement `maphash`, which *does* support such operations, and it used DOHASH in places which perform such operations, so I think it's clear we do want to support `puthash` there. > BTW, I'm using the code below for CL packages, which have a hash table. > A bit less hideous ;-) Nice. The motivation for the change from `DOHASH (h, i)` to `DOHASH (h, k, v)` was not only to offer cleaner code but also to avoid reloading `h->key_and_value` and `h->table_size` at every iteration (`h->key_and_value` is particularly annoying because it's on the critical path to load `key` and `value`). Stefan