From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Stefan Monnier via "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#69056: 30.0.50; history-add-new-input and recursive minibuffers
Date: Thu, 15 Feb 2024 14:20:08 -0500
Message-ID: <jwv8r3l8rkx.fsf-monnier+emacs@gnu.org>
References: <m11q9jngho.fsf@dazzs-mbp.home>
 <jwvplwxah1w.fsf-monnier+emacs@gnu.org>
 <m1v86pln1l.fsf@dazzs-mbp.home>
 <jwvwmr58vth.fsf-monnier+emacs@gnu.org>
 <m17cj5woyq.fsf@dazzs-mbp.home>
Reply-To: Stefan Monnier <monnier@iro.umontreal.ca>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="31845"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13)
Cc: 69056@debbugs.gnu.org
To: Eshel Yaron <me@eshelyaron.com>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 15 20:20:59 2024
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1rahI2-00086q-MU
	for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Feb 2024 20:20:58 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1rahHs-0006ht-Qv; Thu, 15 Feb 2024 14:20:48 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rahHo-0006hN-0W
 for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 14:20:47 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rahHn-0003B5-OM
 for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 14:20:43 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rahI6-0004yL-HK
 for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 14:21:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Stefan Monnier <monnier@iro.umontreal.ca>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Thu, 15 Feb 2024 19:21:02 +0000
Resent-Message-ID: <handler.69056.B69056.170802483919047@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 69056
X-GNU-PR-Package: emacs
Original-Received: via spool by 69056-submit@debbugs.gnu.org id=B69056.170802483919047
 (code B ref 69056); Thu, 15 Feb 2024 19:21:02 +0000
Original-Received: (at 69056) by debbugs.gnu.org; 15 Feb 2024 19:20:39 +0000
Original-Received: from localhost ([127.0.0.1]:57085 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1rahHj-0004x9-7o
 for submit@debbugs.gnu.org; Thu, 15 Feb 2024 14:20:39 -0500
Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38391)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@iro.umontreal.ca>) id 1rahHf-0004wg-R5
 for 69056@debbugs.gnu.org; Thu, 15 Feb 2024 14:20:38 -0500
Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6B9A61000C3;
 Thu, 15 Feb 2024 14:20:10 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1708024809;
 bh=OGxQN897ymGsmqog4wFnheuFbr5rx+F4evb3ZgSh0pU=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=lxoEwTCjK2HC9KFPlznfMlxUCytqLn5rSIBRRDZ3zCGyByzlcp9b6kQKTz34liBc0
 +w1sdYpxD0l6HZT7x5wIRSVJ+YXcLlNJN2+5xjpXxAr0c2znI+hFXWlL9E2fgIJSlw
 d1iBraNPOkBpfxCuN5+hipHngmp0UFJJrmcCYaVJuri5iFeqstRx2+ETastOpveP0p
 t/B+tisZWb5twhfSq8VK976cdySzbJAobVJWqz5fA4LYs667VCk8qMF8Am3nPH8kXs
 KCqwZ1eJArdwb+k32ps+n94B33c74pHZD9ioeGe6msFtZVNOl6rIn2gHUtgzv78dSV
 JSuKTnZYlL+Kg==
Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7490510004B;
 Thu, 15 Feb 2024 14:20:09 -0500 (EST)
Original-Received: from alfajor (unknown [23.233.149.155])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 59DD812027F;
 Thu, 15 Feb 2024 14:20:09 -0500 (EST)
In-Reply-To: <m17cj5woyq.fsf@dazzs-mbp.home> (Eshel Yaron's message of "Thu,
 15 Feb 2024 19:40:29 +0100")
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:280075
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/280075>

>> Why not use `Vhistory_add_new_input`?
> Good question, I guess for some reason I assumed that `NILP (Vfoo)`
> doesn't check the buffer-local value like `find_symbol_value (Qfoo)`
> does...

The handling of Vfoo is quite delicate, but it does give you the value
in the current-buffer (i.e. they're changed as needed whenever we go
through `set_buffer`).

> Oh, that's much simpler indeed.  And it seems to work just as well.
> Here's an updated patch (v2):

LGTM.
Eli&Stefan, any objection?


        Stefan