From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Philip Kaludercic <philipk@posteo.net>,
iarchivedmywholelife@gmail.com,
Joseph Turner <joseph@breatheoutbreathe.in>,
69528@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Andrea Corallo <acorallo@gnu.org>
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Date: Tue, 04 Jun 2024 18:34:35 -0400 [thread overview]
Message-ID: <jwv8qzkl4z5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADwFkmnWOhKk9wuLmR6B2pSs9PGeHmS4ENfoFarjkkXp539pow@mail.gmail.com> (Stefan Kangas's message of "Tue, 4 Jun 2024 18:19:50 -0400")
>>>>> * lisp/emacs-lisp/lisp-mnt.el (lm-version): Prefer version in the
>>>>> "Package-Version:" header. (Bug#69528)
>>>> BTW, I think this is a backward-incompatible change.
>>>> Whether we want `lm-version` to return the info from `Version:` or from
>>>> `Package-Version:` depends on what we want to do with it.
> AFAICT, we currently use it in `lm-report-bug' and with Joseph's patch
> we will use it also for `loaddefs-generate--parse-file'.
`lm-report-bug` does not seem directly related to ELPA packaging, so it
makes sense to use just `Version:` there, which is presumably the format
that the maintainer favors (where the `Package-Version:` header is
instead the format that the maintainer was forced to add to accommodate
the restrictions of the ELPA protocol).
In contrast, `loaddefs-generate--parse-file' is about generating info
for `package.el`, so this one *does* want to use `Package-Version:`
if it's present.
Of course `lm-report-bug` would work likely fine as well if it uses
`Package-Version:`. The distinction is probably not that important in
that case.
> I don't have a strong opinion, but there seems to be a mismatch between
> what the code does and what the documentation says.
>
> "The version number comes from the ‘Package-Version’ header, if it
> exists, or from the ‘Version’ header otherwise."
>
> (info "(elisp) Simple Packages")
Definitely. My only point was that the patch changed `lm-version` in
a backward incompatible way (tho arguably a minor one) without even
mentioning it.
Maybe it's OK to do that, but let's do it consciously.
If not, then we'll presumably add a new `lm-package-version` (which
wouldn't look at RCS keywords either).
Stefan
next prev parent reply other threads:[~2024-06-04 22:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 17:25 bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions No Wayman
2024-03-04 17:22 ` No Wayman
2024-03-04 18:41 ` Philip Kaludercic
2024-03-05 6:17 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09 6:53 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 7:39 ` Eli Zaretskii
2024-05-25 8:04 ` Philip Kaludercic
2024-05-25 8:08 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 8:47 ` Philip Kaludercic
2024-05-26 0:45 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 10:49 ` Eli Zaretskii
2024-06-02 10:36 ` Stefan Kangas
2024-06-02 11:07 ` Philip Kaludercic
2024-06-02 12:08 ` Stefan Kangas
2024-06-02 13:11 ` Philip Kaludercic
2024-06-02 18:26 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 18:40 ` Philip Kaludercic
2024-06-03 17:24 ` Stefan Kangas
2024-06-03 19:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 19:58 ` Philip Kaludercic
2024-06-03 20:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 22:19 ` Stefan Kangas
2024-06-04 22:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-06-04 22:22 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8qzkl4z5.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=69528@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=eliz@gnu.org \
--cc=iarchivedmywholelife@gmail.com \
--cc=joseph@breatheoutbreathe.in \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.