From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#75336: [PATCH] Allow pcomplete of git add to include untracked files. Date: Sat, 04 Jan 2025 10:04:31 -0500 Message-ID: References: <86frlzf1zo.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31924"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Augusto Stoffel , 75336@debbugs.gnu.org To: Peter Seibel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 16:05:25 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU5iN-00089u-Nu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 16:05:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU5i6-0003fn-PP; Sat, 04 Jan 2025 10:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU5i2-0003dg-6a for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 10:05:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU5i1-0005mR-UP for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 10:05:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=mTpr2bnwhCe5PMsFkt11wB3zKM8fI1305pfuMmvVd8I=; b=qA/0hTtP9HeQ8HZE9Q/0OTVDdTqwc1CZ/LUaqT4KdC91EK3esH5mTI1THy4HqW/48jdu9nCyPpRhC84Ziut4gcVnn5PJm7HUKjcltZdv5smFpp/XpxyoM/4872vLxwNtr6JehAFCss+L9T7iDedJQK9N5mD+0mG0nd8ABj0VLwa2a3ZV9zyGMks+/bGniLk/A7FTJNQLEhpCXUGfDs1uoZQEKMy6xRzINen/Bg04cYUfhne+/bUXBuR4dWeob42r7XTPFgkeryWMHET433spxCLHYv9ABRi99TOJdqE7J7ecDnPZ7YnUu+DrnNHucRgOgUlg799YZS4AJ2boRmJnhA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU5i1-0004lv-NX for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 10:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75336 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75336-submit@debbugs.gnu.org id=B75336.173600308218312 (code B ref 75336); Sat, 04 Jan 2025 15:05:01 +0000 Original-Received: (at 75336) by debbugs.gnu.org; 4 Jan 2025 15:04:42 +0000 Original-Received: from localhost ([127.0.0.1]:56640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU5hi-0004lI-Cf for submit@debbugs.gnu.org; Sat, 04 Jan 2025 10:04:42 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28008) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU5hf-0004l1-Ge for 75336@debbugs.gnu.org; Sat, 04 Jan 2025 10:04:40 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B275A440F0E; Sat, 4 Jan 2025 10:04:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1736003072; bh=vWgNaBB+TyJuUtqdpnCsIaStgzKXG6d14nPkKmrvkjU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=W6NPz0StSgnLKiuflNfDakN5vFfxF2BkqV/h8OjS2OUbaZ8iJ/nWPughOVX19qmG5 M6YzLgkcpKKlos8btmu7wHoR2TAHqbl16SmkgUn0W5V5HiSb/FtdIApCsGE2YkMcja zVTjwxHq8exAb+RlprUXSLUo4UJBy63UtdgtlQz9eRD4OjpnPwBe0FB+DYSBMLHghE gMd/0qfrD4oo0DEkDZWkSDimKVyxhzXdkxg8FyW5wNNX1nkDx8Vpmkmb5RhYCBNRaX MYRXDO6Dx7gR0J/EObjhUVy7Hi4ZtVqndXfopVG6YKcw+LyS7r+Q7gNsFdl8poHNE4 SYKZpI/CoYlrA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 869B1440DBD; Sat, 4 Jan 2025 10:04:32 -0500 (EST) Original-Received: from pastel (104-195-236-84.cpe.teksavvy.com [104.195.236.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 549B41202C1; Sat, 4 Jan 2025 10:04:32 -0500 (EST) In-Reply-To: (Peter Seibel's message of "Sat, 4 Jan 2025 05:59:18 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298419 Archived-At: >> > I was going a bit crazy trying to figure out why tab completion in >> > *shell* wasn't working for git add when I was trying to add a new >> > file to my repo. Turns out pcomplete was only completing modified >> > tracked files. This patch changes it so after git add it also >> > completes untracked non-ignored files. >> Augusto and Stefan, any comments? The (new) patch looks good to me. FWIW, it also makes sense occasionally to `git add` ignored files (e.g. we could want to track a `.elc` file in the test suite inside the Emacs repository to check how we handle specific old-format `.elc` files). Stefan