From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Peter Seibel <peter@gigamonkeys.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
Augusto Stoffel <arstoffel@gmail.com>,
75336@debbugs.gnu.org
Subject: bug#75336: [PATCH] Allow pcomplete of git add to include untracked files.
Date: Sat, 04 Jan 2025 10:04:31 -0500 [thread overview]
Message-ID: <jwv8qrqsk0t.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CALHiJMbC5o30X+vxCLWqfoJJBaTNABFuLveE6dwstQE16=nw7Q@mail.gmail.com> (Peter Seibel's message of "Sat, 4 Jan 2025 05:59:18 -0800")
>> > I was going a bit crazy trying to figure out why tab completion in
>> > *shell* wasn't working for git add when I was trying to add a new
>> > file to my repo. Turns out pcomplete was only completing modified
>> > tracked files. This patch changes it so after git add it also
>> > completes untracked non-ignored files.
>> Augusto and Stefan, any comments?
The (new) patch looks good to me.
FWIW, it also makes sense occasionally to `git add` ignored files
(e.g. we could want to track a `.elc` file in the test suite inside the
Emacs repository to check how we handle specific old-format `.elc`
files).
Stefan
next prev parent reply other threads:[~2025-01-04 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 0:00 bug#75336: [PATCH] Allow pcomplete of git add to include untracked files Peter Seibel
2025-01-04 7:52 ` Eli Zaretskii
2025-01-04 7:54 ` Eli Zaretskii
2025-01-04 13:59 ` Peter Seibel
2025-01-04 15:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2025-01-04 15:52 ` Peter Seibel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8qrqsk0t.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=75336@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=peter@gigamonkeys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.