all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Mysterious fontification/C++ context issue - Patch for	beginning-of-defun-raw.
Date: Fri, 15 Dec 2006 18:33:29 -0500	[thread overview]
Message-ID: <jwv7iwssprd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1Gv5E4-0000Ei-La@fencepost.gnu.org> (Richard Stallman's message of "Fri\, 15 Dec 2006 00\:03\:16 -0500")

> That makes me wonder whether find_defun_start should use
> syntax-begin-function.

Yes, that's what should happen.

> Does that work right?

I don't think we should try that at this stage.  It's post-22 AFAIC.

> If so, we could eliminate open-paren-in-column-0-is-defun-start.
> Stefan suggested something similar: making back_comment use syntax-ppss.

Actually what I intended to suggest is to use it in find_defun_start (which
is used by back_comment).

> How hard is that to implement?

I doubt it'll be a small local change.

> As for fixing the misfontifications of C mode, David Kastrup wrote:

>     The large slowdown most likely would not be necessary if information
>     was reused intelligently and not scanned repeatedly.  That requires a
>     good analysis and careful implementation/reimplementation.

I suspect that the patch I sent a minute ago which sets
font-lock-beginning-of-syntax-function to nil in cc-mode buffers will remove
a large part of the slowdown.

> Should C mode do (setq beginning-of-defun-function 'c-beginning-of-defun)
> Is there any reason that would be bad?

The only reason I could think of is if they want to use the default
beginning-of-defun in font-lock-beginning-of-syntax-function (and they don't
want to do that in cc-mode buffers) or when beginning-of-defun is misused.


        Stefan

  parent reply	other threads:[~2006-12-15 23:33 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-15  5:03 Mysterious fontification/C++ context issue - Patch for beginning-of-defun-raw Richard Stallman
2006-12-15  6:31 ` Sean O'Rourke
2006-12-15 16:08   ` Chong Yidong
2006-12-15 16:16     ` Sean O'Rourke
2006-12-15 16:44       ` Chong Yidong
2006-12-15 20:46         ` Stuart D. Herring
2006-12-15 21:24   ` Richard Stallman
2006-12-15 22:31     ` Sean O'Rourke
2006-12-15 16:57 ` Chong Yidong
2006-12-15 23:33 ` Stefan Monnier [this message]
     [not found] <45742464.1090504@gmx.at>
2006-12-04 21:17 ` Mysterious fontification/C++ context issue Alan Mackenzie
2006-12-06  9:04   ` martin rudalics
2006-12-06 12:22     ` Kim F. Storm
2006-12-06 16:31       ` Chong Yidong
2006-12-07  4:59         ` Richard Stallman
2006-12-10  0:35           ` Alan Mackenzie
2006-12-10  1:11             ` Chong Yidong
2006-12-10  9:12               ` Alan Mackenzie
2006-12-10 20:30                 ` Chong Yidong
2006-12-13 21:29                   ` Mysterious fontification/C++ context issue - Patch for beginning-of-defun-raw Alan Mackenzie
2006-12-14  1:02                     ` Chong Yidong
2006-12-14  7:36                       ` Alan Mackenzie
2006-12-14 10:47                         ` martin rudalics
2006-12-14 18:26                           ` Alan Mackenzie
2006-12-14 18:53                             ` David Kastrup
2006-12-14 20:21                             ` Chong Yidong
2006-12-14 20:35                             ` Chong Yidong
2006-12-14 22:18                               ` Alan Mackenzie
2006-12-14 22:51                                 ` Chong Yidong
2006-12-15  0:53                                 ` David Kastrup
2006-12-15 10:35                                 ` Johan Bockgård
2006-12-15  7:32                             ` martin rudalics
2006-12-15 19:22                               ` Alan Mackenzie
2006-12-15 22:20                                 ` David Kastrup
2006-12-16 10:17                                 ` martin rudalics
2006-12-17 11:44                                   ` Alan Mackenzie
2006-12-17 12:02                                     ` David Kastrup
2006-12-17 12:08                                       ` Alan Mackenzie
2006-12-17 12:14                                         ` David Kastrup
2006-12-17 12:26                                           ` Alan Mackenzie
2006-12-17 12:51                                             ` David Kastrup
2006-12-17 17:28                                     ` martin rudalics
2006-12-18  0:06                                     ` Stefan Monnier
2006-12-15 23:24                           ` Stefan Monnier
2006-12-16 10:17                             ` martin rudalics
2006-12-16 18:14                               ` Chong Yidong
2006-12-16 18:27                               ` martin rudalics
2006-12-16 19:00                                 ` martin rudalics
2006-12-16 19:33                                   ` Chong Yidong
2006-12-16 19:59                                     ` martin rudalics
2006-12-16 20:10                                       ` Chong Yidong
2006-12-16 21:26                                         ` Chong Yidong
2006-12-16 22:43                                           ` martin rudalics
2006-12-16 23:30                                           ` Stefan Monnier
2006-12-16 23:40                                             ` martin rudalics
2006-12-17  0:04                                               ` Stefan Monnier
2006-12-17  4:02                                                 ` Chong Yidong
2006-12-17 10:32                                                   ` martin rudalics
2006-12-17 10:26                                                 ` martin rudalics
2006-12-17 10:59                                                   ` David Kastrup
2006-12-17 23:23                                                   ` Stefan Monnier
2006-12-17 11:10                                                 ` Alan Mackenzie
2006-12-17 12:01                                                   ` David Kastrup
2006-12-18  0:04                                                   ` Stefan Monnier
2006-12-16 22:11                                         ` martin rudalics
2006-12-16 23:29                                       ` Stefan Monnier
2006-12-16 23:37                                         ` martin rudalics
2006-12-16 20:22                                     ` David Kastrup
2006-12-16 22:21                                       ` martin rudalics
2006-12-14 17:29                         ` Chong Yidong
2006-12-14 18:56                           ` David Kastrup
2006-12-14 22:57                           ` Alan Mackenzie
2006-12-15 22:56                       ` Stefan Monnier
2006-12-15 23:03                         ` David Kastrup
2006-12-14 10:45                     ` martin rudalics
2006-12-14 18:29                       ` Alan Mackenzie
2006-12-15 22:49                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7iwssprd.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.