From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: propose adding Icicles to Emacs Date: Mon, 11 Jun 2007 15:17:12 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1181589450 3240 80.91.229.12 (11 Jun 2007 19:17:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2007 19:17:30 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 11 21:17:28 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HxpOJ-0000mP-39 for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2007 21:17:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxpOI-0006LC-9L for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2007 15:17:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HxpOF-0006Kx-39 for emacs-devel@gnu.org; Mon, 11 Jun 2007 15:17:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HxpOE-0006Kl-MI for emacs-devel@gnu.org; Mon, 11 Jun 2007 15:17:22 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxpOE-0006Ki-GH for emacs-devel@gnu.org; Mon, 11 Jun 2007 15:17:22 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HxpOD-0001NR-BA; Mon, 11 Jun 2007 15:17:21 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 9B69B2CF274; Mon, 11 Jun 2007 15:17:20 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id A5BB23FE1; Mon, 11 Jun 2007 15:17:12 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 918AB4C6D25; Mon, 11 Jun 2007 15:17:12 -0400 (EDT) In-Reply-To: (Drew Adams's message of "Mon\, 11 Jun 2007 11\:33\:40 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72638 Archived-At: > The `completing-read' code is here: > http://www.emacswiki.org/cgi-bin/wiki/icicles-fn.el. Perhaps others more > familiar with Emacs implementation can advise whether some of this > redefinition could or should be moved to the vanilla definition of > `completing-read' or what might be a "cleaner way" to do what is done now > this way. I would advise just leaving this code as is, at least for now. Redefining completing-read is a no-no in my book. Please try to rewrite your code so as not to do that (e.g. using minibuffer-setup-hook). Also, if it turns out to be impossible, or very inconvenient, then post a request for enhancement to make it possible/easier. >> it can replace some top-level commands with Icicles >> versions (e.g. `find-file' with `icicle-find-file'). > I should be clear that this is not about redefining commands; it is about > remapping their bindings: the bindings for `find-file' are mapped to > `icicle-find-file'. I.e. find-file is not changed. You just remap C-x C-f to your command, right? That's perfectly fine. Stefan