From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Resizing may delete windows Date: Wed, 02 Apr 2008 10:52:16 -0400 Message-ID: References: <47E42196.8010302@gmail.com> <47E927F4.4000509@gmx.at> <47E9347C.5000905@gmail.com> <47E94B35.4080507@gmx.at> <47E95C8F.4050604@gmail.com> <47E9783C.8060406@gmx.at> <47E9FDD2.4010205@gmx.at> <47EA83A7.9000305@gmx.at> <47EACE96.8020805@gmx.at> <47EB51BE.5060602@gmx.at> <47F34748.1020604@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207147990 28400 80.91.229.12 (2 Apr 2008 14:53:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Apr 2008 14:53:10 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, "Jan D." , "Lennart Borgman \(gmail\)" , Michael Kifer To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 02 16:53:41 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jh4Ko-0004m4-Cx for ged-emacs-devel@m.gmane.org; Wed, 02 Apr 2008 16:53:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jh4KC-0008Uz-6J for ged-emacs-devel@m.gmane.org; Wed, 02 Apr 2008 10:52:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jh4K7-0008Rp-TS for emacs-devel@gnu.org; Wed, 02 Apr 2008 10:52:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jh4K6-0008P3-3z for emacs-devel@gnu.org; Wed, 02 Apr 2008 10:52:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jh4K6-0008Ov-1H for emacs-devel@gnu.org; Wed, 02 Apr 2008 10:52:22 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jh4K5-0003FC-Pq for emacs-devel@gnu.org; Wed, 02 Apr 2008 10:52:21 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Jh4K5-0007su-9n for emacs-pretest-bug@gnu.org; Wed, 02 Apr 2008 10:52:21 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Jh4K2-0003Ck-IR for emacs-pretest-bug@gnu.org; Wed, 02 Apr 2008 10:52:21 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182] helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jh4K2-0003CE-8b for emacs-pretest-bug@gnu.org; Wed, 02 Apr 2008 10:52:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AugEAPY580dMCrUE/2dsb2JhbACBWqsA X-IronPort-AV: E=Sophos;i="4.25,594,1199682000"; d="scan'208";a="17446004" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 02 Apr 2008 10:52:16 -0400 Original-Received: from pastel.home ([76.10.181.4]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id ISC75016; Wed, 02 Apr 2008 10:52:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 5CDCD7FE2; Wed, 2 Apr 2008 10:52:16 -0400 (EDT) In-Reply-To: <47F34748.1020604@gmx.at> (martin rudalics's message of "Wed, 02 Apr 2008 10:43:52 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94199 gmane.emacs.pretest.bugs:21845 Archived-At: >>> I don't understand shrink_windows enough to make it less trigger-happy. >>> From the code I only understand that a high value of `window-min-height' >>> is an invitation to shoot silly windows. >> Yes, that's indeed how it works now. But it would be good to change it >> a bit. And I agree that it's not easy code. > I suppose that `shrink_windows' simply has to take into account the > presence of modelines when checking the min_size of windows. That's > quite tedious to do - I have to alloc a second vector to store the > minimum sizes of all involved windows. I can't think of any reason why the modelines would matter. Just, when rearranging windows because of a change somewhere (frame size or other-window size), try hard not to shrink a window (i.e. prefer shrinking another window) if that shrinkage would cause it to be deleted. > Agreed if "if we can't preserve its size" is read as "if we cannot > establish the new frame-size by other means". That's right. Stefan