From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 591@emacsbugs.donarmstrong.com
Subject: bug#591: 23.0.60; lisp-complete-symbol erases extra text
Date: Tue, 29 Jul 2008 18:07:57 -0400 [thread overview]
Message-ID: <jwv7ib4xs7p.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87ej5czaef.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 29 Jul 2008 16:46:16 -0400")
>> In *scratch*, type this, and leave cursor after the final `for':
>>
>> format-decode-buffer
>> forward-char
>>
>> for
>>
>> Then hit `M-TAB'. Choose one of the completions using mouse-2 in *Completions*.
>>
>> Only the final `for' should be completed, but instead all of the text
>> in the buffer is replaced by the chosen completion.
> Hi Stefan,
> This bug was introduced by your patch:
Yes, I know.
> This sets completion-base-size to 0, which causes the completions buffer
> to delete everything in the Lisp buffer when you make a selection.
The problem is that leaving it nil will revert to the use of
a heuristic. Fixing it right is a bit more difficult.
> I don't understand why we need the (completely undocumented) hack
> introduced here, where the cdr of the last item on the completions list
> gives completion-base-size. Does anything else in Emacs depend on this?
> Why not simply add a new optional argument to display-completion-list?
Yes the base-size in the cdr is a hack, and we be able to get rid of it
now that I've added the new `boundaries' action. But passing it as an
additional argument won't make any difference for the bug at hand.
Stefan
next prev parent reply other threads:[~2008-07-29 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 20:46 bug#591: 23.0.60; lisp-complete-symbol erases extra text Chong Yidong
2008-07-29 21:51 ` Drew Adams
2008-07-29 22:07 ` Stefan Monnier [this message]
2008-07-30 4:36 ` Chong Yidong
2008-10-03 16:55 ` Drew Adams
-- strict thread matches above, loose matches on Subject: below --
2008-07-22 4:43 Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7ib4xs7p.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=591@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.