all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: hash-table-{to, from}-alist
Date: Wed, 26 Nov 2008 13:10:38 -0500	[thread overview]
Message-ID: <jwv7i6qfjlt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86prkiiia2.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 26 Nov 2008 10:06:13 -0600")

> everyone.  I changed it to #s(hash-table ...) as discussed.

Good, thanks.

SM> The same way as the other circularities.  I.e. it should mostly
SM> "just work", except you'll have to change the code that does the
SM> first pass so that it doesn't skip hash tables.
> Sorry, I don't know what you mean.  My iterator doesn't skip hash
> tables, does it?  Or are you discussing something else?

The print code does 2 passes over the data: a first one to collect the
set of objects it's going to print, and a second to do the actual print.
This 2-pass approach is done to handle cycles and sharing (so that when
an object appears several times in the output, we know it right when we
print the first occurrence).  IIUC your patch only patches the second
pass, but not the first.

> IMHO hashtables should always be printed completely and should be
> treated like lists and vectors.  If, however, compatibility with
> XEmacs is desired or people feel strongly for print-readably, I will
> implement with print-readably.

char tables are always printed in full and we haven't had any complaints
about that, so you're probably right: let's just always print them
in full.  If it turns out to be problematic in some cases, we can later
on add some extra variable to control the level of detail.


        Stefan




  reply	other threads:[~2008-11-26 18:10 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28  1:01 print hash table to disk and reread in hash table Xah
2008-08-28  5:21 ` Thierry Volpiatto
     [not found] ` <mailman.17732.1219901096.18990.help-gnu-emacs@gnu.org>
2008-08-28  5:27   ` Xah
2008-08-28  6:17     ` Thierry Volpiatto
2008-08-28 14:03     ` Ted Zlatanov
2008-08-28 18:10       ` Eli Zaretskii
     [not found]       ` <mailman.17796.1219947087.18990.help-gnu-emacs@gnu.org>
2008-08-29 14:06         ` Ted Zlatanov
2008-08-29 14:52           ` Eli Zaretskii
     [not found]           ` <mailman.17897.1220021571.18990.help-gnu-emacs@gnu.org>
2008-08-29 18:10             ` Ted Zlatanov
2008-08-30  5:18               ` tomas
2008-08-30  9:17                 ` Ted Zlatanov
2008-08-30 12:03                   ` tomas
2008-11-17 17:15                   ` Ted Zlatanov
2008-11-19 21:37                     ` hash-table-{to, from}-alist (was: print hash table to disk and reread in hash table) Ted Zlatanov
2008-11-19 21:57                       ` hash-table-{to, from}-alist Glenn Morris
2008-11-20 19:07                         ` Ted Zlatanov
2008-11-21 22:02                       ` Stefan Monnier
2008-11-21 22:22                         ` Ted Zlatanov
2008-11-22  3:18                           ` Stefan Monnier
2008-11-22  5:45                             ` tomas
2008-11-22 12:27                               ` Stephen J. Turnbull
2008-11-22 15:21                                 ` tomas
2008-11-22 17:38                                   ` Stephen J. Turnbull
2008-11-24 15:44                                     ` Richard M Stallman
2008-11-24 16:58                                       ` Stefan Monnier
2008-11-24 17:21                                       ` Ted Zlatanov
2008-11-25  1:50                                         ` Stephen J. Turnbull
2008-11-25 17:33                                           ` Ted Zlatanov
2008-11-25 23:50                                             ` Ted Zlatanov
2008-11-26  1:46                                               ` Stefan Monnier
2008-11-26  2:16                                                 ` David De La Harpe Golden
2008-11-26  3:48                                                   ` Stefan Monnier
2008-11-26  5:46                                                     ` David De La Harpe Golden
2008-11-26  2:29                                             ` Stephen J. Turnbull
2008-11-26  3:34                                               ` David De La Harpe Golden
2008-11-26 16:06                                               ` Ted Zlatanov
2008-11-26 18:10                                                 ` Stefan Monnier [this message]
2008-11-26 20:37                                                   ` Ted Zlatanov
2008-11-26 21:16                                                     ` Ted Zlatanov
2008-12-01 22:01                                                       ` Ted Zlatanov
2008-12-02  0:13                                                         ` Andreas Schwab
2008-12-02 14:27                                                           ` Ted Zlatanov
2008-12-02 21:59                                                           ` Stefan Monnier
2008-12-02 22:20                                                             ` Andreas Schwab
2008-12-02 20:56                                                         ` Ted Zlatanov
2008-12-02 21:27                                                           ` Andreas Schwab
2008-12-02 21:58                                                         ` Stefan Monnier
2008-12-03 19:25                                                           ` Ted Zlatanov
2008-12-04  2:05                                                             ` Stefan Monnier
2008-12-04  6:23                                                               ` Stephen J. Turnbull
2008-12-04  6:34                                                                 ` Miles Bader
2008-12-04  9:08                                                                   ` Andreas Schwab
2008-12-04 13:18                                                                   ` Stefan Monnier
2008-12-04 15:02                                                               ` Ted Zlatanov
2008-12-04 19:34                                                                 ` Stefan Monnier
2008-12-04 19:57                                                                   ` Ted Zlatanov
2009-07-30 18:24                                                                 ` Ted Zlatanov
2009-07-30 19:08                                                                   ` Chong Yidong
2009-07-30 19:22                                                                     ` Ted Zlatanov
2009-07-30 19:40                                                                       ` Chong Yidong
2009-07-30 21:04                                                                         ` Stefan Monnier
2009-07-31  1:30                                                                           ` Stefan Monnier
2009-07-31 17:49                                                                             ` Ted Zlatanov
2009-07-31 19:03                                                                               ` Stefan Monnier
2009-07-31 20:25                                                                                 ` Ted Zlatanov
2009-08-01  2:22                                                                                   ` Stephen J. Turnbull
2009-08-01 11:35                                                                                   ` Chong Yidong
2009-08-03 14:53                                                                                     ` Ted Zlatanov
2009-08-05  9:20                                                                                       ` Ted Zlatanov
2009-08-05 13:48                                                                                         ` Chong Yidong
2009-08-05 16:48                                                                                           ` Ted Zlatanov
2009-08-06 16:30                                                                                             ` Stefan Monnier
2009-08-06 16:47                                                                                               ` Ted Zlatanov
2009-08-08 18:36                                                                                                 ` Chong Yidong
2009-08-06 10:13                                                                                         ` Dan Nicolaescu
2009-08-06 16:58                                                                                         ` Florian Beck
2009-08-03 21:23                                                                                   ` Stefan Monnier
2009-07-31 18:10                                                                           ` Ted Zlatanov
2008-11-27  0:24                                                     ` Stephen J. Turnbull
2008-12-01 21:53                                                       ` Ted Zlatanov
2008-12-02  9:05                                                         ` Stephen J. Turnbull
2008-12-02 14:21                                                           ` Ted Zlatanov
2008-12-02 15:54                                                             ` Stephen J. Turnbull
2008-12-02 16:10                                                               ` Ted Zlatanov
2008-12-02 16:54                                                                 ` Stephen J. Turnbull
2008-12-02 22:19                                                         ` Stefan Monnier
2008-12-02 23:27                                                           ` Ted Zlatanov
2008-11-26 19:44                                                 ` Davis Herring
2008-11-26 20:41                                                   ` Ted Zlatanov
2008-11-25  2:57                                         ` Stefan Monnier
2008-11-25  7:02                                           ` Stephen J. Turnbull
2008-11-22  6:07                             ` Miles Bader
2008-11-22 15:27                               ` tomas
2008-11-22 18:57                             ` Ted Zlatanov
2008-08-28  8:36 ` print hash table to disk and reread in hash table Niels Giesen
2008-10-10 20:38 ` harven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7i6qfjlt.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.