bug#1418: 23.0.60; Wrong character decoding in quail-insert-kbd-layout

bug#1418: 23.0.60; Wrong character decoding in quail-insert-kbd-layout

[Kenichi Handa]

Ulrich Mueller <ulm@kph.uni-mainz.de> wrote:
> the displayed keyboard layout output by describe-input-method for the
> "german" input method (but same problem for others, e.g. "french")
> shows raw 8-bit characters:

Thank you for finding this bug and providing the correct
patch.  I've just installed that patch.

By the way, are there anything I must do to the bug tracking
system when I fixed a specific bug?

---
Kenichi Handa
handa@m17n.org

Re: bug#1418: 23.0.60; Wrong character decoding in quail-insert-kbd-layout

[Chong Yidong]

Kenichi Handa <handa@m17n.org> writes:

> Thank you for finding this bug and providing the correct
> patch.  I've just installed that patch.
>
> By the way, are there anything I must do to the bug tracking
> system when I fixed a specific bug?

When you send the email saying you fixed the bug, add a CC to
NNNN-done@emacsbugs.donarmstrong.com (I've just done that now).  This
closes the bug.  See admin/notes/bugtracker for more information about
using the bug tracker.

bug#1418: 23.0.60; Wrong character decoding in quail-insert-kbd-layout

[Ulrich Mueller]

Hi,

the displayed keyboard layout output by describe-input-method for the
"german" input method (but same problem for others, e.g. "french")
shows raw 8-bit characters:

     +--------------------------------------------------------------------+
     | 1! | 2" | 3\247| 4$ | 5% | 6& | 7/ | 8( | 9) | 0= |\337? | [{ | ]} |
     +--------------------------------------------------------------------+
       | qQ | wW | eE | rR | tT | zZ | uU | iI | oO | pP |\374\334| +* |
       +--------------------------------------------------------------------+
        | aA | sS | dD | fF | gG | hH | jJ | kK | lL |\366\326|\344\304| #^ |
        +-------------------------------------------------------------------+
          | yY | xX | cC | vV | bB | nN | mM | ,; | .: | -_ |
          +-------------------------------------------------+
		    +-----------------------------+
		    |          space bar          |
		    +-----------------------------+

Reproduce with:

   $ emacs -Q
   C-h I german RET

The following patch fixes the problem for me:

--- emacs-orig/lisp/international/quail.el	21 Nov 2008 20:40:16 -0000	1.167
+++ emacs/lisp/international/quail.el	23 Nov 2008 20:37:10 -0000
@@ -830,10 +830,6 @@
 	      (insert-char 32 (+ row (/ (- row 2) 2)))))
 	(setq lower (aref layout i)
 	      upper (aref layout (1+ i)))
-	(if (and (integerp lower) (>= lower 128) (< lower 256))
-	    (setq lower (unibyte-char-to-multibyte lower)))
-	(if (and (integerp upper) (>= upper 128) (< upper 256))
-	    (setq upper (unibyte-char-to-multibyte upper)))
 	(insert bar)
 	(if (= (if (stringp lower) (string-width lower) (char-width lower)) 1)
 	    (insert " "))

Ulrich

bug#1418: marked as done (23.0.60; Wrong character decoding in quail-insert-kbd-layout)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]


Your message dated Fri, 16 Jan 2009 08:09:47 -0500
with message-id <87y6xbe6sk.fsf@cyd.mit.edu>
and subject line Re: bug#1418: 23.0.60; Wrong character decoding in quail-insert-kbd-layout
has caused the Emacs bug report #1418,
regarding 23.0.60; Wrong character decoding in quail-insert-kbd-layout
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1418: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1418
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3972 bytes --]

From: Ulrich Mueller <ulm@kph.uni-mainz.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; Wrong character decoding in quail-insert-kbd-layout
Date: Sun, 23 Nov 2008 21:57:10 +0100
Message-ID: <18729.50086.549469.456282@a1ihome1.kph.uni-mainz.de>

Hi,

the displayed keyboard layout output by describe-input-method for the
"german" input method (but same problem for others, e.g. "french")
shows raw 8-bit characters:

     +--------------------------------------------------------------------+
     | 1! | 2" | 3\247| 4$ | 5% | 6& | 7/ | 8( | 9) | 0= |\337? | [{ | ]} |
     +--------------------------------------------------------------------+
       | qQ | wW | eE | rR | tT | zZ | uU | iI | oO | pP |\374\334| +* |
       +--------------------------------------------------------------------+
        | aA | sS | dD | fF | gG | hH | jJ | kK | lL |\366\326|\344\304| #^ |
        +-------------------------------------------------------------------+
          | yY | xX | cC | vV | bB | nN | mM | ,; | .: | -_ |
          +-------------------------------------------------+
		    +-----------------------------+
		    |          space bar          |
		    +-----------------------------+

Reproduce with:

   $ emacs -Q
   C-h I german RET

The following patch fixes the problem for me:

--- emacs-orig/lisp/international/quail.el	21 Nov 2008 20:40:16 -0000	1.167
+++ emacs/lisp/international/quail.el	23 Nov 2008 20:37:10 -0000
@@ -830,10 +830,6 @@
 	      (insert-char 32 (+ row (/ (- row 2) 2)))))
 	(setq lower (aref layout i)
 	      upper (aref layout (1+ i)))
-	(if (and (integerp lower) (>= lower 128) (< lower 256))
-	    (setq lower (unibyte-char-to-multibyte lower)))
-	(if (and (integerp upper) (>= upper 128) (< upper 256))
-	    (setq upper (unibyte-char-to-multibyte upper)))
 	(insert bar)
 	(if (= (if (stringp lower) (string-width lower) (char-width lower)) 1)
 	    (insert " "))

Ulrich



[-- Attachment #3: Type: message/rfc822, Size: 1855 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Kenichi Handa <handa@m17n.org>
Cc: emacs-devel@gnu.org, ulm@kph.uni-mainz.de, 1418-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1418: 23.0.60; Wrong character decoding in quail-insert-kbd-layout
Date: Fri, 16 Jan 2009 08:09:47 -0500
Message-ID: <87y6xbe6sk.fsf@cyd.mit.edu>

Kenichi Handa <handa@m17n.org> writes:

> Thank you for finding this bug and providing the correct
> patch.  I've just installed that patch.
>
> By the way, are there anything I must do to the bug tracking
> system when I fixed a specific bug?

When you send the email saying you fixed the bug, add a CC to
NNNN-done@emacsbugs.donarmstrong.com (I've just done that now).  This
closes the bug.  See admin/notes/bugtracker for more information about
using the bug tracker.

Re: bug#1418: 23.0.60; Wrong character decoding in quail-insert-kbd-layout

[Kenichi Handa]

In article <87y6xbe6sk.fsf@cyd.mit.edu>, Chong Yidong <cyd@stupidchicken.com> writes:

> Kenichi Handa <handa@m17n.org> writes:
> > Thank you for finding this bug and providing the correct
> > patch.  I've just installed that patch.
> >
> > By the way, are there anything I must do to the bug tracking
> > system when I fixed a specific bug?

> When you send the email saying you fixed the bug, add a CC to
> NNNN-done@emacsbugs.donarmstrong.com (I've just done that now).  This
> closes the bug.  See admin/notes/bugtracker for more information about
> using the bug tracker.

I see, thank you.

---
Kenichi Handa
handa@m17n.org

Re: bug#1418: 23.0.60; Wrong character decoding in quail-insert-kbd-layout

[Stefan Monnier]

>> the displayed keyboard layout output by describe-input-method for the
>> "german" input method (but same problem for others, e.g. "french")
>> shows raw 8-bit characters:

> Thank you for finding this bug and providing the correct
> patch.  I've just installed that patch.

> By the way, are there anything I must do to the bug tracking
> system when I fixed a specific bug?

If the bug was tracked in the bug-tracker, then you should reply to
<bugnb>-done@emacsbugs.donarmstrong.com.  Also you can include
"bug#<bugnb>" in the commit (and ChangeLog) message for cross-reference.


        Stefan