* bug#2730: Patch to fix "Wrong number of arguments" error in with-selected-frame in CVS Emacs
@ 2009-03-20 17:09 Fran Litterio
2009-03-20 21:08 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Fran Litterio @ 2009-03-20 17:09 UTC (permalink / raw)
To: bug-gnu-emacs
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
The following bug exists in CVS Emacs as of 2009-03-20. In lisp/subr.el, the
definition of with-selected-frame has a bug where select-frame is called
with two arguments instead of one. This patch fixes that.
--
Fran Litterio
flitterio@gmail.com
--- subr.el~ 2009-03-20 10:28:52.000492000 -0400
+++ subr.el 2009-03-20 13:04:24.000046000 -0400
@@ -2584,10 +2584,10 @@
`(let ((,old-frame (selected-frame))
(,old-buffer (current-buffer)))
(unwind-protect
- (progn (select-frame ,frame 'norecord)
+ (progn (select-frame ,frame)
,@body)
(when (frame-live-p ,old-frame)
- (select-frame ,old-frame 'norecord))
+ (select-frame ,old-frame))
(when (buffer-live-p ,old-buffer)
(set-buffer ,old-buffer))))))
[-- Attachment #2: Type: text/html, Size: 2462 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#2730: Patch to fix "Wrong number of arguments" error in with-selected-frame in CVS Emacs
2009-03-20 17:09 bug#2730: Patch to fix "Wrong number of arguments" error in with-selected-frame in CVS Emacs Fran Litterio
@ 2009-03-20 21:08 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2009-03-20 21:08 UTC (permalink / raw)
To: Fran Litterio; +Cc: bug-gnu-emacs, 2730
> The following bug exists in CVS Emacs as of 2009-03-20. In lisp/subr.el, the
> definition of with-selected-frame has a bug where select-frame is called
> with two arguments instead of one. This patch fixes that.
C-h f select-frame RET:
(select-frame frame &optional norecord)
...
so the problem you're trying to fix is elsewhere.
Actually, this second argument was added to select-frame specifically
for use in with-selected-frame ;-)
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-20 21:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-20 17:09 bug#2730: Patch to fix "Wrong number of arguments" error in with-selected-frame in CVS Emacs Fran Litterio
2009-03-20 21:08 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.