From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#2982: 23.0.92; `vc-diff' behaves inconsistently with git Date: Sat, 18 Apr 2009 15:38:25 -0400 Message-ID: References: Reply-To: Stefan Monnier , 2982@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1240085088 25828 80.91.229.12 (18 Apr 2009 20:04:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Apr 2009 20:04:48 +0000 (UTC) Cc: gnu-emacs-bug@moderators.isc.org, 2982@emacsbugs.donarmstrong.com To: Markus Triska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 18 22:06:07 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LvGnE-0008LE-GP for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2009 22:05:49 +0200 Original-Received: from localhost ([127.0.0.1]:38395 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvGlp-0000xw-OV for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2009 16:04:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvGlc-0000so-UU for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 16:04:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvGlX-0000q8-FB for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 16:03:59 -0400 Original-Received: from [199.232.76.173] (port=56326 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvGlX-0000pz-8o for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 16:03:55 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60501) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LvGlW-00024Y-HZ for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 16:03:54 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3IK3pSD014273; Sat, 18 Apr 2009 13:03:52 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3IJj5Zt009174; Sat, 18 Apr 2009 12:45:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 18 Apr 2009 19:45:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2982 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2982-submit@emacsbugs.donarmstrong.com id=B2982.12400835147448 (code B ref 2982); Sat, 18 Apr 2009 19:45:05 +0000 Original-Received: (at 2982) by emacsbugs.donarmstrong.com; 18 Apr 2009 19:38:34 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3IJcVGG007437 for <2982@emacsbugs.donarmstrong.com>; Sat, 18 Apr 2009 12:38:32 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai8FAAHJ6UlLd+7D/2dsb2JhbACBTsshg30GhSg X-IronPort-AV: E=Sophos;i="4.40,210,1238990400"; d="scan'208";a="37265466" Original-Received: from 75-119-238-195.dsl.teksavvy.com (HELO pastel.home) ([75.119.238.195]) by ironport2-out.teksavvy.com with ESMTP; 18 Apr 2009 15:38:25 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4997E7EFC; Sat, 18 Apr 2009 15:38:25 -0400 (EDT) In-Reply-To: (Markus Triska's message of "Sat, 18 Apr 2009 19:03:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 18 Apr 2009 16:03:59 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27335 Archived-At: >> So when you open the file, Emacs asks `git' the status of the file and >> so knows that this modtime corresponds to "up-to-date". After `touch', >> OTOH, Emacs isn't so sure any more, so it runs `git diff' > OK, external modtime changes may be harder to handle than an Emacs use > case: Say you resume working on a file with uncommitted changes, and you > first do vc-diff and decide to throw them away. Then in the *vc-diff* > buffer, you do C-u C-c C-a until all chunks are reverted, then save the > file and see if really all changes are gone with C-x v =. At this point > the *vc-diff* buffer is shown unexpectedly without remaining changes. Yup: Emacs has no idea that the buffer-modifications you've performed ended up undoing all the changes. Figuring this out would be a major challenge. In the case of git, it would be easier to ask git the status of the file. Stefan