From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4471: menu-bar menu is undefined Date: Thu, 17 Sep 2009 23:02:50 -0400 Message-ID: References: <87bpl96zgs.fsf@mail.jurta.org> Reply-To: Stefan Monnier , 4471@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253244464 28941 80.91.229.12 (18 Sep 2009 03:27:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Sep 2009 03:27:44 +0000 (UTC) Cc: 4471@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 18 05:27:37 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MoU8G-0006AC-Jz for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Sep 2009 05:27:36 +0200 Original-Received: from localhost ([127.0.0.1]:45389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoU8G-0002Nj-4P for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Sep 2009 23:27:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoU7r-0002Fm-RH for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 23:27:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoU7m-0002EZ-I2 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 23:27:10 -0400 Original-Received: from [199.232.76.173] (port=44636 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoU7m-0002EC-1h for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 23:27:06 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46935) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MoU7l-0001Rf-AM for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 23:27:05 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8I3R1l8026037; Thu, 17 Sep 2009 20:27:02 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8I3A6KJ023682; Thu, 17 Sep 2009 20:10:06 -0700 Resent-Date: Thu, 17 Sep 2009 20:10:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 18 Sep 2009 03:10:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4471 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4471-submit@emacsbugs.donarmstrong.com id=B4471.125324297822138 (code B ref 4471); Fri, 18 Sep 2009 03:10:05 +0000 Original-Received: (at 4471) by emacsbugs.donarmstrong.com; 18 Sep 2009 03:02:58 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8I32uKr022133 for <4471@emacsbugs.donarmstrong.com>; Thu, 17 Sep 2009 20:02:58 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAISVskpLd/GK/2dsb2JhbACBU9MshBwFh34 X-IronPort-AV: E=Sophos;i="4.44,407,1249272000"; d="scan'208";a="45930002" Original-Received: from 75-119-241-138.dsl.teksavvy.com (HELO pastel.home) ([75.119.241.138]) by ironport2-out.pppoe.ca with ESMTP; 17 Sep 2009 23:02:50 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A6B44827E; Thu, 17 Sep 2009 23:02:50 -0400 (EDT) In-Reply-To: <87bpl96zgs.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 18 Sep 2009 00:19:47 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 17 Sep 2009 23:27:10 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31199 Archived-At: > Some menu-bar's menus fail to open in non-toolkit X builds. > For instance, when I click on the "Buffer-Menu" menu-bar's item, > it signals the error: > is undefined > However, with the following patch it displays the menu correctly: > Index: lisp/buff-menu.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v > retrieving revision 1.125 > diff -u -r1.125 buff-menu.el > --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125 > +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000 > @@ -119,7 +119,7 @@ > (defvar Buffer-menu-mode-map > (let ((map (make-keymap)) > - (menu-map (make-sparse-keymap))) > + (menu-map (make-sparse-keymap "Buffer-Menu"))) > (suppress-keymap map t) > (define-key map "v" 'Buffer-menu-select) > (define-key map "2" 'Buffer-menu-2-window) IIUC this is a correct way to fix it, indeed. OTOH it would be better to make the non-toolkit code accept the same keymaps as accepted by the toolkit code. Stefan