From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: 4471@emacsbugs.donarmstrong.com
Subject: bug#4471: menu-bar menu is undefined
Date: Thu, 17 Sep 2009 23:02:50 -0400 [thread overview]
Message-ID: <jwv7hvxyn12.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87bpl96zgs.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 18 Sep 2009 00:19:47 +0300")
> Some menu-bar's menus fail to open in non-toolkit X builds.
> For instance, when I click on the "Buffer-Menu" menu-bar's item,
> it signals the error:
> <menu-bar> <Buffer-menu-mode> <nil> is undefined
> However, with the following patch it displays the menu correctly:
> Index: lisp/buff-menu.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v
> retrieving revision 1.125
> diff -u -r1.125 buff-menu.el
> --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125
> +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000
> @@ -119,7 +119,7 @@
> (defvar Buffer-menu-mode-map
> (let ((map (make-keymap))
> - (menu-map (make-sparse-keymap)))
> + (menu-map (make-sparse-keymap "Buffer-Menu")))
> (suppress-keymap map t)
> (define-key map "v" 'Buffer-menu-select)
> (define-key map "2" 'Buffer-menu-2-window)
IIUC this is a correct way to fix it, indeed.
OTOH it would be better to make the non-toolkit code accept the same
keymaps as accepted by the toolkit code.
Stefan
next prev parent reply other threads:[~2009-09-18 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87pr8ccnkx.fsf@stupidchicken.com>
2009-09-17 21:19 ` bug#4471: menu-bar menu is undefined Juri Linkov
2009-09-18 3:02 ` Stefan Monnier [this message]
2009-10-25 0:50 ` bug#4471: marked as done (menu-bar menu is undefined) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7hvxyn12.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=4471@emacsbugs.donarmstrong.com \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.