From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andreas Roehler <andreas.roehler@online.de>
Cc: emacs-devel@gnu.org, XEmacs-Beta@xemacs.org
Subject: Re: simplifying beginning-of-defun
Date: Sat, 26 Sep 2009 17:44:22 -0400 [thread overview]
Message-ID: <jwv7hvle6o3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4ABE54F9.7090107@online.de> (Andreas Roehler's message of "Sat, 26 Sep 2009 19:52:57 +0200")
> simplifying forms as below should ease maintenance and speed up execution.
To what extent does it preserve compatibility?
Apparently it makes beginning-of-defun-raw ignore
beginning-of-defun-function, and it calls end-of-defun-function with one
argument contrary to the current situation where it's called without
any argument. So your code wouldn't be acceptable as is since it would
likely break several packages.
Which performance problem is it trying to solve?
The main difference I see between your beginning-of-defun and Emacs's
one is that yours doesn't try to handle the case where
beginning-of-defun-function, defun-prompt-regexp, and
open-paren-in-column-0-is-defun-start and all nil. This case was added
fairly recently (Emacs-22, IIRC) after a long discussion. I do not like
this extra case at all, actually, but if you're trying to get rid of it,
please make it a separate thread.
In other words, if you send new code just to simplify the existing one,
than make sure the incompatibilities are clearly understood and
"minor". Otherwise, better focus on the proposal for the change in
behavior, and then accompany that with a patch showing how you suggest
to implement this change.
Stefan
next prev parent reply other threads:[~2009-09-26 21:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 17:52 simplifying beginning-of-defun Andreas Roehler
2009-09-26 21:44 ` Stefan Monnier [this message]
2009-09-27 8:10 ` Andreas Roehler
2009-09-27 18:40 ` Stefan Monnier
2009-09-28 6:50 ` Andreas Roehler
2009-09-28 22:46 ` Stefan Monnier
2009-09-29 6:53 ` Andreas Roehler
2009-09-29 8:29 ` Andreas Roehler
2009-09-27 10:26 ` Andreas Roehler
2009-09-27 11:17 ` Eric M. Ludlam
2009-09-27 18:53 ` Stefan Monnier
2009-09-27 20:07 ` Eric M. Ludlam
2009-09-27 22:52 ` Stefan Monnier
2009-09-28 2:04 ` Eric M. Ludlam
2009-09-28 4:06 ` Stefan Monnier
2009-09-28 11:20 ` Eric M. Ludlam
2009-09-29 6:50 ` Alan Mackenzie
2009-09-27 19:06 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7hvle6o3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=XEmacs-Beta@xemacs.org \
--cc=andreas.roehler@online.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.