From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Michael Reilly <pmr@pajato.com>
Cc: emacs-devel@gnu.org
Subject: Re: compilation-process-setup-function doc bug?
Date: Wed, 04 Nov 2009 21:44:44 -0500 [thread overview]
Message-ID: <jwv7hu53diy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4AF235EA.6090405@pajato.com> (Paul Michael Reilly's message of "Wed, 04 Nov 2009 21:18:18 -0500")
>> Indeed, it appears the doc disagrees with the code.
>> I'm not sure when the problem appeared, but the `compilation-buffer' is
>> (current-buffer). OTOH compilation-window is not
>> immediately available. (get-buffer-window (curent-buffer) 0) will
>> usually return the right window, tho.
> In that case I'd be happy to fix the code by making both variables buffer
> local to the compilation buffer thus making the documentation consistent.
> Unless you would prefer to have the last sentence removed from the
> description and leave it to the User to figure out how to get the buffer or
> window should they need it. My preference is the former.
Since this behavior has been present since at least Emacs-22, I'd just
remove the sentence from the docstring: (current-buffer) is a very good
way to pass a buffer argument. As for the window, if we really want to
pass it, then we should just select it during that call, but I don't
think it's worth the trouble.
Stefan
prev parent reply other threads:[~2009-11-05 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 22:57 compilation-process-setup-function doc bug? Paul Michael Reilly
2009-11-05 1:57 ` Stefan Monnier
2009-11-05 2:18 ` Paul Michael Reilly
2009-11-05 2:44 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7hu53diy.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=pmr@pajato.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.