From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7284: [PATCH] `find-change-log' fails in *derived* Diff modes Date: Tue, 26 Oct 2010 17:35:16 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288129396 3836 80.91.229.12 (26 Oct 2010 21:43:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 26 Oct 2010 21:43:16 +0000 (UTC) Cc: 7284@debbugs.gnu.org To: "Aaron S. Hawley" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 26 23:43:14 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PArIS-0002lV-96 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Oct 2010 23:43:08 +0200 Original-Received: from localhost ([127.0.0.1]:40652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PArIR-0008Hj-Il for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Oct 2010 17:43:07 -0400 Original-Received: from [140.186.70.92] (port=47336 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PArIL-0008FG-Eb for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2010 17:43:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PArIJ-0000tJ-O3 for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2010 17:43:00 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PArIJ-0000t5-Lw for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2010 17:42:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PAr7h-0005UU-Jt; Tue, 26 Oct 2010 17:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Oct 2010 21:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7284-submit@debbugs.gnu.org id=B7284.128812867521090 (code B ref 7284); Tue, 26 Oct 2010 21:32:01 +0000 Original-Received: (at 7284) by debbugs.gnu.org; 26 Oct 2010 21:31:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PAr6x-0005U7-AB for submit@debbugs.gnu.org; Tue, 26 Oct 2010 17:31:15 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PAr6v-0005U2-Jb for 7284@debbugs.gnu.org; Tue, 26 Oct 2010 17:31:14 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o9QLZHBk005632; Tue, 26 Oct 2010 17:35:17 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id C69F4B4681; Tue, 26 Oct 2010 17:35:16 -0400 (EDT) In-Reply-To: (Aaron S. Hawley's message of "Tue, 26 Oct 2010 15:47:43 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3660=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 26 Oct 2010 17:32:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41154 Archived-At: > - (with-current-buffer (let ((buff (if (eq major-mode 'diff-mode) > + (with-current-buffer (let ((buff (if (derived-mode-p 'diff-mode) Thanks. > Perhaps, more of the cases of Emacs's Lisp that have (eq major-mode ...) > should be converted to (derived-mode-p ...). Indeed. > Obviously, they'll need to be studied on a case-by-case basis since > there might be cases when only the exact major-mode is intended to > be matched. These are exceedingly rare. At least, I can't remember las time I came across one of those. Stefan