From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7350: 24.0.50; make vc-deduce-backend smarter Date: Wed, 17 Nov 2010 08:31:26 -0500 Message-ID: References: <19669.54304.980911.220632@rgr.rgrjr.com> <19671.7412.608640.593137@rgr.rgrjr.com> <19672.26151.150217.308712@rgr.rgrjr.com> <19680.28414.314610.707478@rgr.rgrjr.com> <19683.23940.23038.507387@rgr.rgrjr.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1290111315 20300 80.91.229.12 (18 Nov 2010 20:15:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 18 Nov 2010 20:15:15 +0000 (UTC) Cc: 7350@debbugs.gnu.org To: Bob Rogers Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 18 21:15:11 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PJAsx-00031e-2R for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Nov 2010 21:15:11 +0100 Original-Received: from localhost ([127.0.0.1]:58424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJAsw-0005Jo-8C for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Nov 2010 15:15:10 -0500 Original-Received: from [140.186.70.92] (port=60400 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJAsF-0004zI-R4 for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2010 15:14:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJAsB-0000n6-6B for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2010 15:14:27 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJAsB-0000n2-4Z for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2010 15:14:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PJAWZ-0006XR-2F; Thu, 18 Nov 2010 14:52:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Nov 2010 19:52:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7350 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7350-submit@debbugs.gnu.org id=B7350.129010988525087 (code B ref 7350); Thu, 18 Nov 2010 19:52:03 +0000 Original-Received: (at 7350) by debbugs.gnu.org; 18 Nov 2010 19:51:25 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PJAVw-0006WZ-91 for submit@debbugs.gnu.org; Thu, 18 Nov 2010 14:51:24 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PJAVv-0006WC-9i for 7350@debbugs.gnu.org; Thu, 18 Nov 2010 14:51:23 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oAIJuPAH006672; Thu, 18 Nov 2010 14:56:27 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 10F3FA82B4; Wed, 17 Nov 2010 08:31:26 -0500 (EST) In-Reply-To: <19683.23940.23038.507387@rgr.rgrjr.com> (Bob Rogers's message of "Tue, 16 Nov 2010 23:43:48 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3683=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 18 Nov 2010 14:52:03 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41737 Archived-At: > A largish patch is not a problem in and of itself (except for copyright > reasons, but once you've signed the paperwork it's a non-issue). So the > only reason to reject such a change would be if it made the code > conceptually more tricky/complex. From the sound of it, it would make > it actually more regular, more in line with the usual way commands work > in Emacs, so it seems OK. > The problem, of course, is knowing when to stop. ;-} For having looked at this particular part of the code with similar intentions a few years ago, I know. > Anyway, I've appended a work-in-progress patch, FYI. It depends on > refactoring vc-deduce-fileset, which in turn depends on the assumption > that vc-parent-buffer must be registered. Comments welcomed. Thanks for the work-in-progress. Comments will follow. > Grepping found only one caller; vc-log-edit passes it as the > log-edit-diff-function. But this really ought to use the passed > fileset, and not go through the command again, true? Actually, what it *should* do is select the same fileset as the one that C-c C-c will commit. I'm not sure which fileset is chosen by C-c C-c, but if I were to choose, I'd follow the PCL-CVS behavior which is to recompute the fileset rather than use whatever was the fileset when the *VC-Log* buffer was created (but aditionally check whether the new fileset is the same as the old one, and if not prompt the user to make sure that's really what she intended). Stefan